- Notifications
You must be signed in to change notification settings - Fork948
feat: add --quiet flag to coder ssh command#18883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge4 commits intomainChoose a base branch fromfeat/ssh-quiet-flag
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+1,850 −1,777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adds a --quiet (-q) flag to suppress machine setup logs and connectionindicators when connecting to workspaces via SSH. This provides a cleanerSSH experience for users who don't want to see the startup logs.Changes:- Add Quiet field to AgentOptions struct- Modify Agent() function to skip logging in quiet mode- Add --quiet flag with -q shorthand to SSH command- Support CODER_SSH_QUIET environment variableCo-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Fix Go formatting for the quiet flag to match existing code style.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Generate updated CLI documentation that includes the new --quiet flagfor the SSH command.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Run markdownlint and markdown-table-formatter to fix formattingissues in the generated CLI documentation.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--quiet
(-q
) flag to suppress machine setup logs and connection indicators when connecting to workspaces via SSH.Changes
Quiet
field toAgentOptions
struct incli/cliui/agent.go
Agent()
function to skip all logging when quiet mode is enabled--quiet
flag with-q
shorthand to SSH commandCODER_SSH_QUIET
environment variableUsage
Testing
coder ssh --help