Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: prioritize human-initiated workspace builds over prebuilds in queue#18882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
blink-so wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromfeat/priority-queue-human-over-prebuilds

Conversation

blink-so[bot]
Copy link
Contributor

Summary

Implements a priority queue system for provisioner jobs to ensure human-initiated workspace builds are processed before prebuild jobs, improving user experience during high queue periods.

Changes

  • Database: Addedpriority column toprovisioner_jobs table with migration
  • Queue Logic: UpdatedAcquireProvisionerJob query to order bypriority DESC, created_at ASC
  • Priority Assignment: Human-initiated jobs get priority 1, prebuilds get priority 0
  • API: Exposed priority field in SDK and conversion functions
  • Testing: Added comprehensive test to verify priority queue behavior

How it works

  1. When creating provisioner jobs, the workspace builder checks if the initiator is thePrebuildsSystemUserID
  2. Human-initiated jobs getpriority = 1, prebuild jobs getpriority = 0
  3. TheAcquireProvisionerJob query now orders by priority first, then creation time
  4. This ensures human jobs are always acquired before prebuild jobs, regardless of creation time

Testing

  • Added unit test that verifies priority-based job acquisition
  • Test creates both human and prebuild jobs and confirms acquisition order
  • Existing tests should continue to pass as the change is backward compatible

Impact

  • Users: Faster workspace build times when prebuilds are queued
  • System: No performance impact, just changes query ordering
  • Backward Compatibility: Existing jobs get default priority 0, new logic applies to future jobs

Fixes the issue where prebuilds could delay human-initiated workspace builds during busy periods.

…ueueThis change implements a priority queue system for provisioner jobs to ensurethat human-initiated workspace builds are processed before prebuild jobs,improving user experience during high queue periods.Changes:- Add priority column to provisioner_jobs table (1=human, 0=prebuild)- Update AcquireProvisionerJob query to order by priority DESC, created_at ASC- Set priority in workspace builder based on initiator (PrebuildsSystemUserID)- Expose priority field in API and SDK- Add comprehensive test for priority queue behaviorCo-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SasSwartSasSwartAwaiting requested review from SasSwart

@johnstcnjohnstcnAwaiting requested review from johnstcn

At least 1 approving review is required to merge this pull request.

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp