- Notifications
You must be signed in to change notification settings - Fork948
feat: add configurable SSH host key algorithm support#18866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge7 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adds support for configurable SSH host key algorithms to improvecompatibility with modern SSH clients like Visual Studio 2022.Changes:- Add HostKeyAlgorithm field to agentssh.Config- Implement Ed25519 key generation in CoderSigner function- Add CLI flag --ssh-host-key-algorithm with env var support- Support both 'rsa' (default) and 'ed25519' algorithms- Maintain backward compatibility with RSA as defaultResolves compatibility issues with SSH clients that no longersupport RSA host keys.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Remove trailing whitespace from empty lines in agentssh.goto satisfy the formatting requirements.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
@blink instead of making it configurable, can't we just support both algorithms simultaneously? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for configurable SSH host key algorithms to improve compatibility with modern SSH clients like Visual Studio 2022 that no longer support RSA host keys.
Changes
HostKeyAlgorithmfield toagentssh.Config- allows configuration of SSH host key algorithm--ssh-host-key-algorithm- with environment variableCODER_AGENT_SSH_HOST_KEY_ALGORITHMCoderSignerfunction - now accepts algorithm parameter and supports both key typesTesting
Usage
Resolves
This addresses the Visual Studio 2022 compatibility issue where newer SSH clients reject RSA host keys, allowing users to configure Ed25519 which is widely supported and more secure.