- Notifications
You must be signed in to change notification settings - Fork928
feat: add Unhealthy Workspaces filter option#18653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+5 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adds a new preset filter option 'Unhealthy workspaces' to the workspacefiltering interface. This filter shows workspaces with failed status,making it easier for users to quickly identify and manage problematicworkspaces.Changes:- Add 'unhealthy' query mapping to 'status:failed' in workspaceFilterQuery- Add 'Unhealthy workspaces' preset to PRESET_FILTERS arrayThe filter integrates seamlessly with the existing StatusMenu andWorkspacesTable components.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new preset filter option "Unhealthy workspaces" to the workspace filtering interface, making it easier for users to quickly identify and manage problematic workspaces.
Changes
unhealthy: "status:failed"mapping toworkspaceFilterQueryobjectPRESET_FILTERSarrayImplementation Details
The "Unhealthy workspaces" filter maps to
status:failed, treating failed workspaces as unhealthy since they represent non-functional or problematic workspaces. This provides users with:Testing
The implementation integrates seamlessly with existing components:
status:failedis properly handled by the backendTested by examining the existing codebase structure and ensuring the changes follow established patterns.
Co-authored-by: jaaydenh1858163+jaaydenh@users.noreply.github.com