- Notifications
You must be signed in to change notification settings - Fork927
feat: support dynamic parameters on create template request#18636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Emyrk wants to merge2 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+70 −38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Emyrk commentedJun 27, 2025
codersdk/organizations.go Outdated
Comment on lines 204 to 208
| // UseClassicParameterFlow allows optionally specifying whether | ||
| // the template should use the classic parameter flow. The default if unset is | ||
| // true, and is why `*bool` is used here. When dynamic parameters becomes | ||
| // the default, this will default to false. | ||
| UseClassicParameterFlow *bool `json:"template_use_classic_parameter_flow"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The inverted logic is a bit annoying. When dynamic parameters becomes the stable and primary method, then the default isfalse. So this will make sense in 1 to 2 releases.
be970a4 to877e172Compare83e4418 to9f6daa6CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Unsure if the UI will add a checkbox for this.
Unit tests can take advantage of this.