NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

refactor: show apps when workspace is running#18625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 2 commits intomainfrombq/display-apps-right-away

Jun 27, 2025

Merged

refactor: show apps when workspace is running#18625

BrunoQuaresma merged 2 commits intomainfrombq/display-apps-right-away

Jun 27, 2025

+1 −16

Conversation

Copy link

Collaborator

BrunoQuaresma commentedJun 26, 2025

Close#18617

refactor: show apps when workspace is running

d574b17

BrunoQuaresma requested a review fromcode-asher

June 26, 2025 20:49

BrunoQuaresma self-assigned this

Jun 26, 2025

code-asher approved these changes

Jun 26, 2025

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, I wonder though if we can change the previous section toelse if (task.workspace.latest_build.status !== "running")? Because that section says "workspace is not running" so it seems like the perfect section to show if!== "running". Then we could delete the "running your task" section completely.