- Notifications
You must be signed in to change notification settings - Fork927
refactor: show apps when workspace is running#18625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, I wonder though if we can change the previous section toelse if (task.workspace.latest_build.status !== "running")? Because that section says "workspace is not running" so it seems like the perfect section to show if!== "running". Then we could delete the "running your task" section completely.
Close#18617