Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: correct hasAITaskResources logic for child modules#18542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 1 commit intomainfromhugodutka/has-ai-task-resources-fix
Jun 24, 2025

Conversation

hugodutka
Copy link
Contributor

@hugodutkahugodutka commentedJun 24, 2025•
edited
Loading

As far as I can tell, a resource label in the terraform graph is its address.
Resource addresses are prefixed with module paths if they are in child modules.https://developer.hashicorp.com/terraform/internals/json-format#plan-representation

Here's a partial output ofterraform graph -type=plan on a Coder template that defines acoder_ai_task inside a module that confirms this:

digraph {        compound = "true"        newrank = "true"        subgraph "root" {                "[root] coder_agent.dev (expand)" [label = "coder_agent.dev", shape = "box"]                "[root] coder_app.preview (expand)" [label = "coder_app.preview", shape = "box"]                "[root] coder_metadata.container_info (expand)" [label = "coder_metadata.container_info", shape = "box"]                "[root] coder_metadata.home_volume (expand)" [label = "coder_metadata.home_volume", shape = "box"]                "[root] docker_volume.home_volume (expand)" [label = "docker_volume.home_volume", shape = "box"]                ...                "[root] module.claude-code.coder_ai_task.claude_code (expand)" [label = "module.claude-code.coder_ai_task.claude_code", shape = "box"]                "[root] module.claude-code.coder_app.claude_code (expand)" [label = "module.claude-code.coder_app.claude_code", shape = "box"]                "[root] module.claude-code.coder_app.claude_code_web (expand)" [label = "module.claude-code.coder_app.claude_code_web", shape = "box"]                ...        }}

follow up to#18449, related to#18453

@hugodutkahugodutka requested a review fromjohnstcnJune 24, 2025 17:01
@hugodutkahugodutka marked this pull request as ready for reviewJune 24, 2025 17:01
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

@dannykoppingdannykopping merged commitb6c493d intomainJun 24, 2025
46 checks passed
@dannykoppingdannykopping deleted the hugodutka/has-ai-task-resources-fix branchJune 24, 2025 17:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@sreyasreyasreya approved these changes

@johnstcnjohnstcnAwaiting requested review from johnstcn

Assignees

@hugodutkahugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@hugodutka@dannykopping@sreya
[8]ページ先頭
©2009-2025 Movatter.jp