- Notifications
You must be signed in to change notification settings - Fork926
refactor: remove beta label from 'select a preset' menu#18538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
@BrunoQuaresma could you also remove the same beta label from CreateWorkspacePageViewExperiemental for dynamic parameters? |
| @@ -404,11 +404,6 @@ export const CreateWorkspacePageViewExperimental: FC< | |||
| </Tooltip> | |||
| </TooltipProvider> | |||
| </span> | |||
| <FeatureStageBadge | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we be removing the badge for dynamic params as well? AFAIK that's still in beta for a bit longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This badge should definitely stay here. I was expecting the beta badge next to the Preset label on the dynamic parameters create workspace badge would be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, I will rollback the change and@jaaydenh feel free to remove the dynamic parameter badge in another PR
3e3a16b to15ab057Compare
No description provided.