NotificationsYou must be signed in to change notification settings
Fork925
Star10.1k

fix: allow dynamic parameters to consider the prebuilds user an owner#18529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

SasSwart merged 1 commit intomainfromjjs/dynamic-params-system-users

Jun 24, 2025

Merged

fix: allow dynamic parameters to consider the prebuilds user an owner#18529

SasSwart merged 1 commit intomainfromjjs/dynamic-params-system-users

Jun 24, 2025

Conversation

Copy link

Contributor

SasSwart commentedJun 24, 2025•
edited
Loading

This Pull request allows dynamic parameters to list system users in its search for workspace owners. This is necessary to allow prebuilds to reconcile prebuilt workspaces and to delete them.

fix: allow dynamic parameters to consider the prebuilds user an owner

595ba0d

github-actionsbot assignedSasSwart

Jun 24, 2025

SasSwart requested review fromEmyrk andssncferreira

June 24, 2025 14:10

ssncferreira approved these changes

Jun 24, 2025

View reviewed changes

Copy link

Contributor

ssncferreira left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, might be worth checking with@Emyrk to confirm if this has any impact on dynamic parameters. There was a similar issue when deleting prebuilt workspaces from the CLI:https://github.com/coder/coder/pull/18333/files#r2158990408