- Notifications
You must be signed in to change notification settings - Fork925
chore: fix wsproxy flakes#18522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
johnstcn approved these changesJun 24, 2025
9d148e9 intomain 36 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flake 1:coder/internal#326
This hasn't occurred at all within the last 3 months according to DataDog (except test run cancellations), and I couldn't recreate it on my workspace. I redid a bit of the test logic to make it do some more tests during the wait stages.
Flake 2:coder/internal#278
This flake hasn't occurred in the last 3 months either, and I also couldn't recreate it. I relaxed some of the assertions in the send packet loop for the tests to hopefully be more lenient. I also lowered the amount of replicas we use in this test so we have much less opportunities to fail. Went down from 21 cases to 6 cases which still cover all scenarios.
Closescoder/internal#326
Closescoder/internal#278