Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add workspace build status to task page#18520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 7 commits intomainfromasher/task-build-status
Jun 24, 2025

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedJun 24, 2025•
edited
Loading

I think this might need to be rebased on the latest changes, (done) but this adds a progress bar and the most recent build stage.

I only did this for workspaces starting up, but we could do it for when the workspace is shutting down as well.

Although I tried adding a story for the build log, the mock web socket keeps closing in Storybook before it gets any logs, so I had to skip it. Not sure what is going on there...

recording.mp4

Closes#18183

@code-ashercode-asherforce-pushed theasher/task-build-status branch 3 times, most recently from25c41d7 tocb7a768CompareJune 24, 2025 17:52
@code-ashercode-asher marked this pull request as ready for reviewJune 24, 2025 18:30
Copy link
Contributor

@hugodutkahugodutka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! Minor nits:

  1. can we remove the "this should take a few minutes" text? it's redundant now that we have the progress indicator
  2. can we put "Starting workspace..." and "Up to X seconds remaining..." on separate lines?

@code-asher
Copy link
MemberAuthor

can we remove the "this should take a few minutes" text? it's redundant now that we have the progress indicator

Good point! Done.

can we put "Starting workspace..." and "Up to X seconds remaining..." on separate lines?

How is this?
screenshot

@hugodutka
Copy link
Contributor

It'd look a bit better if the text was centered and the progress bar was at the bottom

@code-asher
Copy link
MemberAuthor

Hmm actually the "starting workspace..." part is also redundant, let me remove that instead of stacking the two lines.

@code-asher
Copy link
MemberAuthor

code-asher commentedJun 24, 2025•
edited
Loading

Here it is at the bottom, wdyt about right vs center when it is at the bottom? I kinda like right but could go either way.

screenshot

screenshot

@code-asher
Copy link
MemberAuthor

Another possibility, I like the remaining time near the progress bar though personally

screenshot

@hugodutka
Copy link
Contributor

458555717-9ce13ae0-5a42-4499-93d9-4159449d30bc
this one looks amazing!

code-asher reacted with hooray emoji

@code-ashercode-asher merged commit288ec77 intomainJun 24, 2025
33 checks passed
@code-ashercode-asher deleted the asher/task-build-status branchJune 24, 2025 21:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@hugodutkahugodutkahugodutka approved these changes

Assignees

@code-ashercode-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tasks: provide a better progress update when workspace is spinning up
2 participants
@code-asher@hugodutka
[8]ページ先頭
©2009-2025 Movatter.jp