- Notifications
You must be signed in to change notification settings - Fork924
chore: improve dynamic parameter validation errors#18501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Emyrk wants to merge1 commit intostevenmasley/dynamic_validateChoose a base branch fromstevenmasley/dynamic_valid_errors
base:stevenmasley/dynamic_validate
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+160 −56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJun 23, 2025
MemberAuthor
Emyrk commentedJun 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
0e3dc00
toa51570a
Compare0923f4d
to817afe8
Compare This was referencedJun 23, 2025
817afe8
to21556db
Comparec1d05a0
to129235b
Compare21556db
to5f30d20
Compare129235b
to6a5ee9e
Compare5f30d20
to40063cd
Compare6a5ee9e
to0523a2f
Compare0523a2f
tof4e5548
Compare686b2f7
to6849a80
Comparef4e5548
to0523a2f
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What this does
The current
BuildError
response fromwsbuilder
does not support rich errors from validation. Changed this to use theValidations
block of codersdk responses to return all errors for invalid parameters.Example http response
Cli error