Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: fix validation error during workspace creation without preset#18494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SasSwart merged 4 commits intomainfromjjs/18430
Jun 24, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -201,6 +201,46 @@ export const PresetReselected: Story = {
},
};

export const PresetNoneSelected: Story = {
args: {
...PresetsButNoneSelected.args,
onSubmit: (request, owner) => {
// Assert that template_version_preset_id is not present in the request
console.assert(
!("template_version_preset_id" in request),
'template_version_preset_id should not be present when "None" is selected',
);
action("onSubmit")(request, owner);
},
},
play: async ({ canvasElement }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤩

const canvas = within(canvasElement);

// First select a preset to set the field value
await userEvent.click(canvas.getByLabelText("Preset"));
await userEvent.click(canvas.getByText("Preset 1"));

// Then select "None" to unset the field value
await userEvent.click(canvas.getByLabelText("Preset"));
await userEvent.click(canvas.getByText("None"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this potentially too vague? Perhaps not now as we control the test but considering future changes.


// Fill in required fields and submit to test the API call
await userEvent.type(
canvas.getByLabelText("Workspace Name"),
"test-workspace",
);
await userEvent.click(canvas.getByText("Create workspace"));
},
parameters: {
docs: {
description: {
story:
"This story tests that when 'None' preset is selected, the template_version_preset_id field is not included in the form submission. The story first selects a preset to set the field value, then selects 'None' to unset it, and finally submits the form to verify the API call behavior.",
},
},
},
};

export const ExternalAuth: Story = {
args: {
externalAuth: [
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -369,7 +369,8 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
setSelectedPresetIndex(index);
form.setFieldValue(
"template_version_preset_id",
option?.value,
// Empty string is equivalent to using None
option?.value === "" ? undefined : option?.value,
);
}}
placeholder="Select a preset"
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -563,6 +563,10 @@ export const CreateWorkspacePageViewExperimental: FC<
return;
}
setSelectedPresetIndex(index);
form.setFieldValue(
"template_version_preset_id",
index === 0 ? undefined : option,
);
}}
>
<SelectTrigger>
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp