- Notifications
You must be signed in to change notification settings - Fork923
fix: fix validation error during workspace creation without preset#18494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not my area so will need FE approval before merging, but seems fine to me
Thanks for the fix 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM great test addition 🌟
Uh oh!
There was an error while loading.Please reload this page.
| action("onSubmit")(request, owner); | ||
| }, | ||
| }, | ||
| play: async ({ canvasElement }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍🏻
| // Then select "None" to unset the field value | ||
| await userEvent.click(canvas.getByLabelText("Preset")); | ||
| await userEvent.click(canvas.getByText("None")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this potentially too vague? Perhaps not now as we control the test but considering future changes.
use option?.value instead of index to check whether we should send a preset ID when a workspace is createdCo-authored-by: Susana Ferreira <susana@coder.com>
4f98fd4 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
closes#18430.
Selecting a preset, and then selecting the "None" preset used to set the preset ID to an empty string instead of
undefined. This sent""to the backend, which expects a valid UUID.