- Notifications
You must be signed in to change notification settings - Fork925
feat: implement efficient backend querying on the tasks page#18488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
3883a22 toc4d88d5Comparec4d88d5 to4f403ddCompare4b753a6 tof62da9dCompare4f403dd to69a2e2dComparef62da9d tof114f43Compare69a2e2d to97a00baComparef114f43 tobf23151Compare97a00ba to604f994Compare
code-asher left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code looks good to me!
I tried it out and my template is not showing up in the dropdown and my workspace does not show in the table, but from my brief glance at the sql I think this is just because thehas_ai_task column is always false at the moment?
| @@ -211,7 +247,7 @@ const TaskForm: FC<TaskFormProps> = ({ templates }) => { | |||
| form.reset(); | |||
| } catch (error) { | |||
| const message = getErrorMessage(error, "Error creating task"); | |||
| const detail = getErrorDetail(error) ?? "Please, try again"; | |||
| const detail = getErrorDetail(error) ?? "Please try again"; | |||
code-asherJun 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Extremely minor, just noticing that this error message has no comma but the ones on 174 and 379 do. Personally I like it better without a comma.
| /> | ||
| ); | ||
| } | ||
| if (templates == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also minor: I think the linter is fine with this, but everywhere else we do=== null (triple equals) or justif (templates).
1273e3c to5a42c7eCompare604f994 tob791c0aCompare1d2b96b intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Use the
/workspaces?q=has-ai-task=true,/templates?q=has-ai-task=trueand/aitasks/promptsendpoints to fetch Task templates and workspaces on the/taskspage.Also:
Related to#18454 andcoder/internal#660.
DANGER: this PR must be merged only after all issues mentioned in#18454 are closed to avoid breaking the dogfood environment.