- Notifications
You must be signed in to change notification settings - Fork924
feat: persist generatedcoder_app id#18487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+50 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
| @@ -967,6 +967,9 @@ func TestConvertResources(t *testing.T) { | |||
| ifagent.GetInstanceId()!="" { | |||
| agent.Auth=&proto.Agent_InstanceId{} | |||
| } | |||
| for_,app:=rangeagent.Apps { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For test reproducibility; see above.
johnstcn approved these changesJun 23, 2025
| @@ -266,6 +266,7 @@ message App { | |||
| bool hidden = 11; | |||
| AppOpenIn open_in = 12; | |||
| string group = 13; | |||
| string id = 14; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe worth mentioning the nil/zero-id behaviour in a comment here?
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
66e8dbb intomain 37 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for#18453 and#18449
coder_appresourcesgenerate new IDs upon creation, but we don't use that value currently. We need this value to persist since the newcoder_ai_taskresource will depend on it.