- Notifications
You must be signed in to change notification settings - Fork924
feat: persist generatedcoder_app id#18487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
| @@ -967,6 +967,9 @@ func TestConvertResources(t *testing.T) { | |||
| if agent.GetInstanceId() != "" { | |||
| agent.Auth = &proto.Agent_InstanceId{} | |||
| } | |||
| for _, app := range agent.Apps { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For test reproducibility; see above.
| @@ -266,6 +266,7 @@ message App { | |||
| bool hidden = 11; | |||
| AppOpenIn open_in = 12; | |||
| string group = 13; | |||
| string id = 14; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe worth mentioning the nil/zero-id behaviour in a comment here?
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
66e8dbb intomainUh oh!
There was an error while loading.Please reload this page.
Prerequisite for#18453 and#18449
coder_appresourcesgenerate new IDs upon creation, but we don't use that value currently. We need this value to persist since the newcoder_ai_taskresource will depend on it.