- Notifications
You must be signed in to change notification settings - Fork920
fix!: do not create provisioner job for orphan delete#18460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
+268 −52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Closing in favour of#18465 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
release/breakingThis label is applied to PRs to detect breaking changes as part of the release process
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#18080
NOTE: calling this out as a breaking change so that it is highly visible in the changelog.
This modifies wsbuilder to no longer create a workspace build when orphan is set.
As a consequence of this,
POST /api/v2/workspaces/{id}/buildswill return a 204 No Content when a workspace is successfully deleted with the--orphanoption.