Jun 18, 2025 · Jun 18, 2025 · Jun 18, 2025
diff --git a/agent/agent.go b/agent/agent.go
 // channel to synchronize the results and avoid both messy
 // mutex logic and overloading the API.
 for _, md := range manifest.Metadata {
 md := md
 // We send the result to the channel in the goroutine to avoid
 // sending the same result multiple times. So, we don't care about
 // the return values.
diff --git a/agent/agent_test.go b/agent/agent_test.go
 t.Parallel()

 for _, port := range sshPorts {
 port := port
 t.Run(fmt.Sprintf("(:%d)", port), func(t *testing.T) {
 t.Parallel()

 t.Parallel()

 for _, port := range sshPorts {
 port := port
 t.Run(fmt.Sprintf("(:%d)", port), func(t *testing.T) {
 t.Parallel()

 }

 for _, port := range sshPorts {
 port := port
 t.Run(fmt.Sprintf("(%d)", port), func(t *testing.T) {
 t.Parallel()

 }

 for _, test := range tests {
 test := test
 t.Run(test.name, func(t *testing.T) {
 t.Parallel()
 session := setupSSHSession(t, test.manifest, test.banner, func(fs afero.Fs) {

 //nolint:paralleltest // These tests need to swap the banner func.
 for _, port := range sshPorts {
 port := port

 sshClient, err := conn.SSHClientOnPort(ctx, port)
 require.NoError(t, err)
 t.Cleanup(func() {
 _ = sshClient.Close()
 })

 for i, test := range tests {
 test := test
 t.Run(fmt.Sprintf("(:%d)/%d", port, i), func(t *testing.T) {
 // Set new banner func and wait for the agent to call it to update the
 // banner.
 t.Parallel()

 for _, key := range []string{"CODER", "CODER_WORKSPACE_NAME", "CODER_WORKSPACE_AGENT_NAME"} {
 key := key
 t.Run(key, func(t *testing.T) {
 t.Parallel()

 // For some reason this test produces a TTY locally and a non-TTY in CI
 // so we don't test for the absence of SSH_TTY.
 for _, key := range []string{"SSH_CONNECTION", "SSH_CLIENT"} {
 key := key
 t.Run(key, func(t *testing.T) {
 t.Parallel()

 },
 }
 for _, tt := range tests {
 tt := tt
 t.Run(tt.key, func(t *testing.T) {
 t.Parallel()

 t.Setenv("LANG", "C")

 for _, backendType := range backends {
 backendType := backendType
 t.Run(backendType, func(t *testing.T) {
 if backendType == "Screen" {
 if runtime.GOOS != "linux" {
 }

 for _, c := range cases {
 c := c
 t.Run(c.name, func(t *testing.T) {
 t.Parallel()

diff --git a/agent/agentcontainers/containers_internal_test.go b/agent/agentcontainers/containers_internal_test.go
 },
 }
 for _, tt := range tests {
 tt := tt // appease the linter even though this isn't needed anymore
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()
 actualCmd, actualArgs := wrapDockerExec("my-container", tt.containerUser, tt.cmdArgs[0], tt.cmdArgs[1:]...)
 func TestConvertDockerPort(t *testing.T) {
 t.Parallel()

 //nolint:paralleltest // variable recapture no longer required
 for _, tc := range []struct {
 name          string
 in            string
 expectError: "invalid port",
 },
 } {
 //nolint: paralleltest // variable recapture no longer required
 t.Run(tc.name, func(t *testing.T) {
 t.Parallel()
 actualPort, actualNetwork, actualErr := convertDockerPort(tc.in)
 expectError: "invalid volume",
 },
 } {
 tc := tc
 t.Run(tc.name, func(t *testing.T) {
 t.Parallel()
 })
diff --git a/agent/agentscripts/agentscripts.go b/agent/agentscripts/agentscripts.go
 if script.Cron == "" {
 continue
 }
 script := script
 _, err := r.cron.AddFunc(script.Cron, func() {
 err := r.trackRun(r.cronCtx, script.WorkspaceAgentScript, ExecuteCronScripts)
 if err != nil {
 continue
 }

 script := script
 eg.Go(func() error {
 err := r.trackRun(ctx, script.WorkspaceAgentScript, option)
 if err != nil {
diff --git a/agent/agentssh/x11_internal_test.go b/agent/agentssh/x11_internal_test.go
 require.NoError(t, err)

 for _, tt := range tests {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()

diff --git a/agent/proto/compare_test.go b/agent/proto/compare_test.go
 eq: false,
 },
 } {
 tc := tc
 t.Run(tc.name, func(t *testing.T) {
 t.Parallel()
 require.Equal(t, tc.eq, proto.LabelsEqual(tc.a, tc.b))
diff --git a/agent/proto/resourcesmonitor/queue_test.go b/agent/proto/resourcesmonitor/queue_test.go
 }

 for _, tt := range tests {
 tt := tt

 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()
 queue := resourcesmonitor.NewQueue(20)
diff --git a/agent/proto/resourcesmonitor/resources_monitor_test.go b/agent/proto/resourcesmonitor/resources_monitor_test.go
 }

 for _, tt := range tests {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()

diff --git a/apiversion/apiversion_test.go b/apiversion/apiversion_test.go
 expectedError: "no longer supported",
 },
 } {
 tc := tc
 t.Run(tc.name, func(t *testing.T) {
 t.Parallel()

diff --git a/buildinfo/buildinfo_test.go b/buildinfo/buildinfo_test.go
 }

 for _, c := range cases {
 c := c
 t.Run(c.name, func(t *testing.T) {
 t.Parallel()
 require.Equal(t, c.expectMatch, buildinfo.VersionsMatch(c.v1, c.v2),
diff --git a/cli/agent_internal_test.go b/cli/agent_internal_test.go
 },
 }
 for _, tt := range tests {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()
 got, err := extractPort(tt.urlString)
diff --git a/cli/autoupdate_test.go b/cli/autoupdate_test.go
 }

 for _, c := range cases {
 c := c
 t.Run(c.Name, func(t *testing.T) {
 t.Parallel()
 client := coderdtest.New(t, nil)
diff --git a/cli/clitest/golden.go b/cli/clitest/golden.go
 }

 for _, tt := range cases {
 tt := tt
 t.Run(tt.Name, func(t *testing.T) {
 t.Parallel()
 ctx := testutil.Context(t, testutil.WaitLong)
diff --git a/cli/cliui/agent_test.go b/cli/cliui/agent_test.go
 wantErr: true,
 },
 } {
 tc := tc
 t.Run(tc.name, func(t *testing.T) {
 t.Parallel()

 },
 }
 for _, tc := range testCases {
 tc := tc
 t.Run(tc.name, func(t *testing.T) {
 t.Parallel()
 r, w := io.Pipe()
 },
 }
 for _, tc := range testCases {
 tc := tc
 t.Run(tc.name, func(t *testing.T) {
 t.Parallel()
 r, w := io.Pipe()
diff --git a/cli/cliui/provisionerjob_test.go b/cli/cliui/provisionerjob_test.go
 }

 for _, tc := range tests {
 tc := tc

 t.Run(tc.name, func(t *testing.T) {
 t.Parallel()

diff --git a/cli/cliui/resources_internal_test.go b/cli/cliui/resources_internal_test.go
 },
 }
 for _, testCase := range testCases {
 testCase := testCase
 t.Run(testCase.name, func(t *testing.T) {
 t.Parallel()
 actual := renderAgentVersion(testCase.agentVersion, testCase.serverVersion)
diff --git a/cli/cliui/table_test.go b/cli/cliui/table_test.go
 // Test with pointer values.
 inPtr := make([]*tableTest1, len(in))
 for i, v := range in {
 v := v
 inPtr[i] = &v
 }
 out, err = cliui.DisplayTable(inPtr, "", nil)
diff --git a/cli/cliutil/levenshtein/levenshtein_test.go b/cli/cliutil/levenshtein/levenshtein_test.go
 Expected:    []string{"kubernetes"},
 },
 } {
 tt := tt
 t.Run(tt.Name, func(t *testing.T) {
 t.Parallel()
 actual := levenshtein.Matches(tt.Needle, tt.MaxDistance, tt.Haystack...)
 Error:   levenshtein.ErrMaxDist.Error(),
 },
 } {
 tt := tt
 t.Run(tt.Name, func(t *testing.T) {
 t.Parallel()
 actual, err := levenshtein.Distance(tt.A, tt.B, tt.MaxDist)
diff --git a/cli/cliutil/provisionerwarn_test.go b/cli/cliutil/provisionerwarn_test.go
 },
 },
 } {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()
 var w strings.Builder
diff --git a/cli/configssh_internal_test.go b/cli/configssh_internal_test.go
 }

 for _, tc := range testCases {
 tc := tc
 t.Run(tc.Name, func(t *testing.T) {
 t.Parallel()

 }
 // nolint:paralleltest // Fixes a flake
 for _, tt := range tests {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 if runtime.GOOS == "windows" {
 t.Skip("Windows doesn't typically execute via /bin/sh or cmd.exe, so this test is not applicable.")
 }
 // nolint:paralleltest // Fixes a flake
 for _, tt := range tests {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 cmd := "/bin/sh"
 arg := "-c"
 },
 }
 for _, tt := range tests {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()
 found, err := sshConfigProxyCommandEscape(tt.path, tt.forceUnix)
 }

 for _, tt := range testCases {
 tt := tt
 t.Run(tt.Name, func(t *testing.T) {
 t.Parallel()

diff --git a/cli/configssh_test.go b/cli/configssh_test.go
 },
 }
 for _, tt := range tests {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()

diff --git a/cli/exp_errors_test.go b/cli/exp_errors_test.go
 }

 for _, tt := range cases {
 tt := tt
 t.Run(tt.Name, func(t *testing.T) {
 t.Parallel()

diff --git a/cli/gitauth/askpass_test.go b/cli/gitauth/askpass_test.go
 wantHost: "http://wow.io",
 },
 } {
 tc := tc
 t.Run(tc.in, func(t *testing.T) {
 t.Parallel()
 user, host, err := gitauth.ParseAskpass(tc.in)
diff --git a/cli/notifications_test.go b/cli/notifications_test.go
 }

 for _, tt := range tests {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()

diff --git a/cli/open_internal_test.go b/cli/open_internal_test.go
 {"fail with no working directory and rel path on windows", args{relOrAbsPath: "my\\path", agentOS: "windows"}, "", true},
 }
 for _, tt := range tests {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()

 expectedLink:      "https://coder.tld/path-base/@username/Test-Workspace.a-workspace-agent/apps/app-slug/",
 },
 } {
 tt := tt
 t.Run(tt.name, func(t *testing.T) {
 t.Parallel()
 baseURL, err := url.Parse(tt.baseURL)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -547,7 +547,6 @@ func (a *agent) reportMetadata(ctx context.Context, aAPI proto.DRPCAgentClient26
		// channel to synchronize the results and avoid both messy
		// mutex logic and overloading the API.
		for _, md := range manifest.Metadata {
		md := md
		// We send the result to the channel in the goroutine to avoid
		// sending the same result multiple times. So, we don't care about
		// the return values.
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -130,7 +130,6 @@ func TestAgent_Stats_SSH(t *testing.T) {
		t.Parallel()

		for _, port := range sshPorts {
		port := port
		t.Run(fmt.Sprintf("(:%d)", port), func(t *testing.T) {
		t.Parallel()

Expand DownExpand Up		@@ -342,7 +341,6 @@ func TestAgent_SessionExec(t *testing.T) {
		t.Parallel()

		for _, port := range sshPorts {
		port := port
		t.Run(fmt.Sprintf("(:%d)", port), func(t *testing.T) {
		t.Parallel()

Expand DownExpand Up		@@ -468,7 +466,6 @@ func TestAgent_SessionTTYShell(t *testing.T) {
		}

		for _, port := range sshPorts {
		port := port
		t.Run(fmt.Sprintf("(%d)", port), func(t *testing.T) {
		t.Parallel()

Expand DownExpand Up		@@ -611,7 +608,6 @@ func TestAgent_Session_TTY_MOTD(t *testing.T) {
		}

		for _, test := range tests {
		test := test
		t.Run(test.name, func(t *testing.T) {
		t.Parallel()
		session := setupSSHSession(t, test.manifest, test.banner, func(fs afero.Fs) {
Expand DownExpand Up		@@ -688,16 +684,13 @@ func TestAgent_Session_TTY_MOTD_Update(t *testing.T) {

		//nolint:paralleltest // These tests need to swap the banner func.
		for _, port := range sshPorts {
		port := port

		sshClient, err := conn.SSHClientOnPort(ctx, port)
		require.NoError(t, err)
		t.Cleanup(func() {
		_ = sshClient.Close()
		})

		for i, test := range tests {
		test := test
		t.Run(fmt.Sprintf("(:%d)/%d", port, i), func(t *testing.T) {
		// Set new banner func and wait for the agent to call it to update the
		// banner.
Expand DownExpand Up		@@ -1210,7 +1203,6 @@ func TestAgent_CoderEnvVars(t *testing.T) {
		t.Parallel()

		for _, key := range []string{"CODER", "CODER_WORKSPACE_NAME", "CODER_WORKSPACE_AGENT_NAME"} {
		key := key
		t.Run(key, func(t *testing.T) {
		t.Parallel()

Expand All		@@ -1233,7 +1225,6 @@ func TestAgent_SSHConnectionEnvVars(t *testing.T) {
		// For some reason this test produces a TTY locally and a non-TTY in CI
		// so we don't test for the absence of SSH_TTY.
		for _, key := range []string{"SSH_CONNECTION", "SSH_CLIENT"} {
		key := key
		t.Run(key, func(t *testing.T) {
		t.Parallel()

Expand DownExpand Up		@@ -1276,7 +1267,6 @@ func TestAgent_SSHConnectionLoginVars(t *testing.T) {
		},
		}
		for _, tt := range tests {
		tt := tt
		t.Run(tt.key, func(t *testing.T) {
		t.Parallel()

Expand DownExpand Up		@@ -1796,7 +1786,6 @@ func TestAgent_ReconnectingPTY(t *testing.T) {
		t.Setenv("LANG", "C")

		for _, backendType := range backends {
		backendType := backendType
		t.Run(backendType, func(t *testing.T) {
		if backendType == "Screen" {
		if runtime.GOOS != "linux" {
Expand DownExpand Up		@@ -2496,7 +2485,6 @@ func TestAgent_Dial(t *testing.T) {
		}

		for _, c := range cases {
		c := c
		t.Run(c.name, func(t *testing.T) {
		t.Parallel()

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -41,7 +41,6 @@ func TestWrapDockerExec(t *testing.T) {
		},
		}
		for _, tt := range tests {
		tt := tt // appease the linter even though this isn't needed anymore
		t.Run(tt.name, func(t *testing.T) {
		t.Parallel()
		actualCmd, actualArgs := wrapDockerExec("my-container", tt.containerUser, tt.cmdArgs[0], tt.cmdArgs[1:]...)
Expand All		@@ -54,7 +53,6 @@ func TestWrapDockerExec(t *testing.T) {
		func TestConvertDockerPort(t *testing.T) {
		t.Parallel()

		//nolint:paralleltest // variable recapture no longer required
		for _, tc := range []struct {
		name string
		in string
Expand DownExpand Up		@@ -101,7 +99,6 @@ func TestConvertDockerPort(t *testing.T) {
		expectError: "invalid port",
		},
		} {
		//nolint: paralleltest // variable recapture no longer required
		t.Run(tc.name, func(t *testing.T) {
		t.Parallel()
		actualPort, actualNetwork, actualErr := convertDockerPort(tc.in)
Expand DownExpand Up		@@ -151,7 +148,6 @@ func TestConvertDockerVolume(t *testing.T) {
		expectError: "invalid volume",
		},
		} {
		tc := tc
		t.Run(tc.name, func(t *testing.T) {
		t.Parallel()
		})
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -177,7 +177,6 @@ func (r *Runner) Init(scripts []codersdk.WorkspaceAgentScript, scriptCompleted S
		if script.Cron == "" {
		continue
		}
		script := script
		_, err := r.cron.AddFunc(script.Cron, func() {
		err := r.trackRun(r.cronCtx, script.WorkspaceAgentScript, ExecuteCronScripts)
		if err != nil {
Expand DownExpand Up		@@ -254,7 +253,6 @@ func (r *Runner) Execute(ctx context.Context, option ExecuteOption) error {
		continue
		}

		script := script
		eg.Go(func() error {
		err := r.trackRun(ctx, script.WorkspaceAgentScript, option)
		if err != nil {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -228,7 +228,6 @@ func Test_addXauthEntry(t *testing.T) {
		require.NoError(t, err)

		for _, tt := range tests {
		tt := tt
		t.Run(tt.name, func(t *testing.T) {
		t.Parallel()

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -67,7 +67,6 @@ func TestLabelsEqual(t *testing.T) {
		eq: false,
		},
		} {
		tc := tc
		t.Run(tc.name, func(t *testing.T) {
		t.Parallel()
		require.Equal(t, tc.eq, proto.LabelsEqual(tc.a, tc.b))
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -65,8 +65,6 @@ func TestResourceMonitorQueue(t *testing.T) {
		}

		for _, tt := range tests {
		tt := tt

		t.Run(tt.name, func(t *testing.T) {
		t.Parallel()
		queue := resourcesmonitor.NewQueue(20)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -195,7 +195,6 @@ func TestPushResourcesMonitoringWithConfig(t *testing.T) {
		}

		for _, tt := range tests {
		tt := tt
		t.Run(tt.name, func(t *testing.T) {
		t.Parallel()

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -72,7 +72,6 @@ func TestAPIVersionValidate(t *testing.T) {
		expectedError: "no longer supported",
		},
		} {
		tc := tc
		t.Run(tc.name, func(t *testing.T) {
		t.Parallel()

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -93,7 +93,6 @@ func TestBuildInfo(t *testing.T) {
		}

		for _, c := range cases {
		c := c
		t.Run(c.name, func(t *testing.T) {
		t.Parallel()
		require.Equal(t, c.expectMatch, buildinfo.VersionsMatch(c.v1, c.v2),
Expand Down