NotificationsYou must be signed in to change notification settings
Fork915
Star10.1k

chore: remove unnecessary redeclarations in for loops#18440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

aslilac wants to merge3 commits intomain

base:main

Choose a base branch

fromlilac/go-122-range-fix

Open

chore: remove unnecessary redeclarations in for loops#18440

aslilac wants to merge3 commits intomainfromlilac/go-122-range-fix

+0 −455

Conversation

Copy link

Member

aslilac commentedJun 18, 2025

disclaimer: I asked claude 4 to do this little bit of cleanup.

I noticed we still have a bunch of these, but these kinds of re-declarations are no longer necessary now that we live in a post go 1.22 world. not a huge change, but didn't take claude very long. :p

chore: remove unnecessary redelarations in for loops

d8ea897

aslilac requested review fromspikecurtis andjohnstcn ascode owners

June 18, 2025 21:38

github-actionsbot assignedaslilac

Jun 18, 2025

johnstcn reviewed

Jun 18, 2025

View reviewed changes

Copy link

Member

johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for doing this! I checked and as far as I can tell this should all be safe. If we wanted to be super-safe, we'd just do the ones in*_test.go and leave the rest till after code freeze.
There are still a few straggling comments left that can also probably be removed.