- Notifications
You must be signed in to change notification settings - Fork914
fix!: stop workspace before update#18425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
This reverts commitc33f9b9.
42420b1 tofa2d4ebCompare| @@ -21,19 +20,39 @@ export interface ActionButtonProps { | |||
| tooltipText?:string; | |||
| } | |||
| exportconstUpdateButton:FC<ActionButtonProps>=({ | |||
| exportconstUpdateAndStartButton:FC<ActionButtonProps>=({ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would probably keep this as one component that takes a prop likeisRunning or something to change the text, since that seems to be the main difference
| loading, | ||
| })=>{ | ||
| return( | ||
| <Tooltiptitle="Stop workspace, if running, and restart it with the latest template version."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| <Tooltiptitle="Stop workspace, if running, and restart it with the latest template version."> | |
| <Tooltiptitle="Stop workspace and restart it with the latest template version."> |
more confident wording. unless I'm misunderstanding, that's the point of this change.
| exportconstUpdateAndStartButton:FC<ActionButtonProps>=({ | ||
| handleAction, | ||
| })=>{ | ||
| exportconstUpdateAndStartButtonRequireActiveVersion:FC< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
similarly, this could also just be anactiveVersionRequired prop, rather than exponentially increasing the number ofUpdate(.+)Button(.+?) components we have
Uh oh!
There was an error while loading.Please reload this page.
Fixes#17840
NOTE: calling this out as a breaking change so that it is highly visible in the changelog.
coder updateto stop the workspace if already running.