- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: add idle app status#18415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
c649ea1 to86cf445Comparehugodutka approved these changesJun 18, 2025
Contributor
hugodutka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, pending the down migration
coderd/database/migrations/000338_workspace_app_status_idle.down.sql OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
"Idle" is more accurate than "complete" since:1. AgentAPI only knows if the screen is active; it has no way of knowing if the task is complete.2. The LLM might be done with its current prompt, but that does not mean the task is complete either (it likely needs refinement).The "complete" state will be reserved for future definition.
The status row looks janky with just the icon. We can get into a "nomessage" state if the LLM never reported a status update.
Also bump migration number since new ones have merged since.
86cf445 tob64af42Compare0a483ea intomain 33 of 34 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
"Idle" is more accurate than "complete" since:
The "complete" state will be reserved for future definition.
Additionally, in the case where the screen goes idle but the LLM never reported a status update, we can get an idle icon without a message, and it looks kinda janky in the UI so if there is no message I display the state text.
Closescoder/internal#699