Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: migrate Alert component from MUI to shadcn#18412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
blink-so wants to merge5 commits intomain
base:main
Choose a base branch
Loading
fromfeat/migrate-alert-to-shadcn

Conversation

@blink-so
Copy link
Contributor

@blink-soblink-sobot commentedJun 17, 2025•
edited by jaaydenh
Loading

Summary

This PR migrates the Alert component from MUI to shadcn implementation while maintaining full backward compatibility with the existing API.

Changes

Core Alert Component

  • Replaced MUI Alert with shadcn-based implementation usingclass-variance-authority
  • Maintained backward compatibility with all existing props:
    • severity (info, success, warning, error)
    • dismissible for showing dismiss button
    • actions for custom action buttons
    • onDismiss callback
  • Added proper Tailwind CSS styling with dark mode support
  • Preserved accessibility features withrole=\"alert\"

Updated Imports

Updated 6 files that were importingAlertTitle from MUI to use our new implementation:

  • ChangeWorkspaceVersionDialog.tsx
  • ProvisionerAlert.tsx
  • GitDeviceAuth.tsx
  • OverviewPageView.tsx
  • Workspace.tsx
  • SetupPageView.tsx

@jaaydenhjaaydenh self-assigned thisJun 18, 2025
@jaaydenhjaaydenh marked this pull request as draftJune 18, 2025 13:27
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJun 28, 2025
@jaaydenhjaaydenh reopened thisAug 12, 2025
@jaaydenhjaaydenh marked this pull request as ready for reviewAugust 12, 2025 16:45
@aslilac
Copy link
Member

I definitely want to see this happen, but even just looking at the first few stories I see a number of things that aren't quite right. not sure how to get blink to fix any of this without eyes.

@jaaydenh
Copy link
Contributor

jaaydenh commentedAug 12, 2025•
edited
Loading

@aslilac sorry about the noise, my intention was only to reopen this and test out coder tasks on cleaning it up. I didn't explicitly set it ready for review or request your review. I wonder if that could have happened automatically somehow or if Claude (through coder tasks) was able to do that itself.

Maybe it has something to do with you being a codeowner?

@aslilac
Copy link
Member

yeah, I think CODEOWNERs only kicks in when you mark it as ready. no worries tho, just lmk when you'd like a review!

@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelAug 13, 2025
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelAug 21, 2025
@jaaydenhjaaydenh reopened thisDec 4, 2025
blink-sobotand others added3 commitsDecember 4, 2025 22:37
- Replace MUI Alert with shadcn-based implementation using class-variance-authority- Maintain backward compatibility with existing Alert API (severity, dismissible, actions, onDismiss)- Update AlertTitle imports across codebase to use new implementation- Add proper Tailwind CSS styling with dark mode support- Preserve accessibility features and smooth animations- Support all existing severity levels: info, success, warning, errorCo-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
@jaaydenhjaaydenhforce-pushed thefeat/migrate-alert-to-shadcn branch fromfdc83a5 toa8ecfd4CompareDecember 4, 2025 22:40
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelDec 5, 2025
@jaaydenhjaaydenh marked this pull request as draftDecember 7, 2025 15:15
@jaaydenhjaaydenh removed the request for review fromaslilacDecember 7, 2025 15:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@jaaydenhjaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aslilac@jaaydenh
[8]ページ先頭
©2009-2025 Movatter.jp