- Notifications
You must be signed in to change notification settings - Fork914
feat: implement conditional build parameters flow based on template setting#18390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Add ConditionalBuildParametersPopover component that checks template_use_classic_parameter_flow- When classic flow is false, show UpdateBuildParametersDialogExperimental for ephemeral parameters- Direct users to workspace settings page for ephemeral parameter configuration- Update WorkspaceParametersPageViewExperimental to combine standard and ephemeral parameters- Add visual indicators for ephemeral parameters in unified parameter display- Update all workspace action buttons to use conditional logicCo-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
- Remove trailing whitespace from ConditionalBuildParametersPopover.tsx- Fix import order in RetryButton.tsx to match linting requirementsCo-authored-by: jaaydenh <1858163+jaaydenh@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements conditional logic for build parameter flows based on the
template_use_classic_parameter_flowworkspace setting. When this setting isfalse, the system now directs users to the workspace settings page for ephemeral parameter configuration instead of using the inline popover.Changes
New Component
BuildParametersPopoveror shows theUpdateBuildParametersDialogExperimentaldialogUpdated Components
StartButtonandRestartButtonto useConditionalBuildParametersPopoverConditionalBuildParametersPopoverConditionalBuildParametersPopoverBehavior Changes
When
template_use_classic_parameter_flowistrue:BuildParametersPopoverbehavior (no change)When
template_use_classic_parameter_flowisfalse:Rationale
This change addresses the requirement that ephemeral parameters may depend on values of non-ephemeral parameters. By directing users to the workspace settings page, they can see and configure all parameters in context, ensuring proper dependency handling.
Testing
The changes maintain backward compatibility - workspaces with
template_use_classic_parameter_flow: truewill continue to work exactly as before. The new flow only activates when the setting isfalse.Related Issues
Addresses the need for better ephemeral parameter handling in the experimental parameter flow.