- Notifications
You must be signed in to change notification settings - Fork912
feat: improve PR deployment workflow performance and functionality#18334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
blink-so wants to merge4 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+454 −22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Implement wildcard certificate optimization to reduce deployment time by 2-5 minutes- Improve automatic redeployment logic to handle non-code changes properly- Add PR comment-triggered deployment functionality (/deploy)- Enable branch deployment without requiring PR creation- Optimize build process with Go and Node module caching- Add comprehensive documentation for all improvementsAddresses issues raised in#11331 to reduce deployment time from >10 minutes to 2-7 minutes.Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
- Handle pull_request events using github.event.number- Handle push events by finding PR for the branch- Improve error handling and validation for PR state checking- Fix issue where gh pr view failed on merge commitsCo-authored-by: matifali <10648092+matifali@users.noreply.github.com>
/deploy |
Fixes markdown linting error MD032/blanks-around-listsCo-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Fixes markdown linting error MD031/blanks-around-fencesCo-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the performance and functionality issues raised in#11331 by implementing comprehensive improvements to the PR deployment workflow.
Key Improvements
🚀 Performance Optimizations
✨ New Features
/deploypull_requestevents and improved event handlingExpected Impact
Changes Made
.github/workflows/pr-deploy.yamlwith all improvements.github/pr-deployments/wildcard-certificate.yamlfor certificate optimizationPR_DEPLOYMENT_IMPROVEMENTS.mdTesting
Closes#11331