- Notifications
You must be signed in to change notification settings - Fork913
feat: support devcontainer agents in ui and unify backend#18332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c9f4ca4 to18e1593Comparefc1a236 to414b6f4Compare414b6f4 toecfe483Compare8f12d26 to79e1844CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
haven't managed to read all the Go yet but will read it by Monday
| return ( | ||
| <HelpTooltip> | ||
| <HelpTooltipTrigger> | ||
| <span role="status" css={{ cursor: "pointer" }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: css
| <spanrole="status"css={{cursor:"pointer"}}> | |
| <spanrole="status"class="cursor-pointer"> |
| const versionLabelStyles = { | ||
| fontWeight: 600, | ||
| color: theme.palette.text.primary, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: is this used anywhere?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This PR adds consolidates two container endpoints on the backend and improves the frontend devcontainer support by showing names and displaying apps as appropriate.
With this change, the frontend now has knowledge of the subagent and we can also display things like port forwards.
The frontend was updated to show dev container labels on the border as well as subagent connection status. The recreation flow was also adjusted a bit to show placeholder app icons when relevant.
Support for
appswas also added, although these are still WIP on the backend. And the port forwarding utility was added in since the sub agents now provide the necessary info.Fixescoder/internal#666