Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(enterprise/coderd): skip org membership check for prebuilds user on group patch#18329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 3 commits intomainfromcj/patch-group-skip-prebuilds-user
Jun 23, 2025

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedJun 11, 2025
edited by dannykopping
Loading

Currently, the prebuilds documentation states:

### Managing resource quotasPrebuilt workspaces can be used in conjunction with [resource quotas](../../users/quotas.md).Because unclaimed prebuilt workspaces are owned by the `prebuilds` user, you can:1. Configure quotas for any group that includes this user.1. Set appropriate limits to balance prebuilt workspace availability with resource constraints.If a quota is exceeded, the prebuilt workspace will fail provisioning the same way other workspaces do.

If you need to have a separate quota for prebuilds as opposed to regular users, you are required to create a separate group, as quotas are applied to groups.

Currently it is not possible to create a separate 'prebuilds' group with only the prebuilds user to add a quota. This PR skips the org membership check specifically for the prebuilds user when patching a group.

image

@johnstcnjohnstcn self-assigned thisJun 11, 2025
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love your bias-to-action, my man ❤️

johnstcn reacted with heart emoji
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJun 19, 2025
@johnstcnjohnstcn merged commit0a12ec5 intomainJun 23, 2025
34 checks passed
@johnstcnjohnstcn deleted the cj/patch-group-skip-prebuilds-user branchJune 23, 2025 09:32
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 23, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@SasSwartSasSwartAwaiting requested review from SasSwart

Assignees

@johnstcnjohnstcn

Labels
staleThis issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@johnstcn@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp