Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add organization scope for shared ports#18314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
aslilac wants to merge25 commits intomain
base:main
Choose a base branch
Loading
fromlilac/org-port-sharing

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedJun 10, 2025
edited
Loading

Fair warning: I made Claude 4 Opus Thinking implement this for me, and then I spent a day working back from it's solution to end up here. Please forgive me sins if I missed something awful while reviewing the code. 🙃 It definitely needed a bunch of tweaking, and missed a bunch of tangential but necessary changes.

Closes#17247

When sharing a port, you can now choose "organization" as a level. This fills a middle ground between "literally any authenticated user" and "only me".

Copy link
Contributor

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

restricted my review just to the proto changes.

@@ -101,4 +101,7 @@ Read [cursor rules](.cursorrules).

##Frontend

The frontend is contained in the site folder.

For building Frontend refer to[this document](docs/contributing/frontend.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems like this line and the next one directly contradict each other.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

it seemed to help prevent claude from trying to run commands not mentioned in that doc from the root of the repo for me. 🤷‍♀️

@aslilacaslilac requested a review fromjohnstcnJune 16, 2025 17:22
@aslilacaslilac requested a review fromjaaydenhJune 16, 2025 18:33
@jaaydenh
Copy link
Contributor

jaaydenh commentedJun 16, 2025
edited
Loading

@aslilac When I test port sharing using the Coder with Claude Code template, when I attempt to share a port on the organization level or change an existing shared port to organization, I get a 400 response with the error below. Even if this is expected, its a bit confusing because there is no indication in the UI of an error.

{    "message": "Port sharing level not allowed.",    "validations": [        {            "field": "share_level",            "detail": "Port sharing level not allowed."        }    ]}

@aslilac
Copy link
MemberAuthor

are you testing against a local backend or the dev backend?

@jaaydenh
Copy link
Contributor

jaaydenh commentedJun 16, 2025
edited
Loading

I am testing against dev. I do notice the error UI does eventually appear if I 1. click the port share button with organization selected 2. after the button press, click both the port input and the sharing level dropdown. So its just a bit convoluted to get the error message to appear. Ideally the error message would appear when the response is received after pressing the share port button.

Maybe this issue was always there but its more obvious with organization port sharing?

Screenshot 2025-06-16 at 21 53 34

@aslilac
Copy link
MemberAuthor

aslilac commentedJun 16, 2025
edited
Loading

you're only hitting this error because the dev backend does not support the new type yet. I'm not really concerned about the error message being good because it should never happen. your frontend version doesn't match the backend version, which we don't usually optimize for.

@aslilac
Copy link
MemberAuthor

if you wanna test this locally, you'll need to set theCODER_WILDCARD_ACCESS_URL to something like*.coder.example.com, and then make sure you set the max sharing level to something other than owner at the bottom of the /templates/:org/:template/settings page.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@spikecurtisspikecurtisspikecurtis left review comments

@DanielleMaywoodDanielleMaywoodDanielleMaywood left review comments

@johnstcnjohnstcnjohnstcn approved these changes

@jaaydenhjaaydenhAwaiting requested review from jaaydenh

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add organization scope to shared ports
5 participants
@aslilac@jaaydenh@johnstcn@spikecurtis@DanielleMaywood

[8]ページ先頭

©2009-2025 Movatter.jp