- Notifications
You must be signed in to change notification settings - Fork913
feat: add organization scope for shared ports#18314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
This reverts commit408d70d.
| OWNER = 1; | ||
| AUTHENTICATED = 2; | ||
| PUBLIC = 3; | ||
| ORGANIZATION = 4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This could also be added in theCreateSubAgentRequest/App/Share message.
Lines 404 to 408 in068f9a0
| enumShare { | |
| OWNER=0; | |
| AUTHENTICATED=1; | |
| PUBLIC=2; | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
any chance you can explain to me what a subagent is and why I would want to add that here? it makes sense on its face but I have no idea what a subagent is 💀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It’s just an agent that has a parent agent that manages its lifecycle. They’re being used for our dev container feature where we inject agents into a dev container during the runtime (not startup) of a workspace. So they’re for all intents and purposes normal agents, just with a different lifecycle.
Uh oh!
There was an error while loading.Please reload this page.
Fair warning: I made Claude 4 Opus Thinking implement this for me, and then I spent a day working back from it's solution to end up here. Please forgive me sins if I missed something awful while reviewing the code. 🙃 It definitely needed a bunch of tweaking, and missed a bunch of tangential but necessary changes.
Closes#17247
When sharing a port, you can now choose "organization" as a level. This fills a middle ground between "literally any authenticated user" and "only me".