- Notifications
You must be signed in to change notification settings - Fork909
feat: use proto streams to increase maximum module files payload#18268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Emyrk wants to merge34 commits intomainChoose a base branch fromstevenmasley/4mb
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Increase maximum module files payload using protobuf streams
Problem
Coder has a4MB protobuf message size limit that prevents templates with large Terraform modules from being processed. When dynamic parameters require module files from
~/.terraform/modules
that exceed this limit, template creation fails.Solution
This PR implements protobuf streaming to handle large module files by:
Key Changes
Architecture
Coderd↔️ Provisionerd: Uses new streaming RPC when payload exceeds limits.
coder/provisionerd/proto/provisionerd.proto
Lines 220 to 222 ine880894
Provisionerd↔️ Provisioner: Extends existing stream with new message types for in-memory communication
This change enables templates with arbitrarily large Terraform modules while maintaining performance through deduplication and preserving the existing fast path for smaller payloads.
TODO:
Things that I wish I could change
DataUpload
andChunk
would be defined in 1 place and have their types reusable in both contexts 😢.