Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: show preset parameters when they have diagnostics#18258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 2 commits intomainfromfix/show-preset-parameters-with-diagnostics
Jun 5, 2025

Conversation

blink-so[bot]
Copy link
Contributor

@blink-soblink-sobot commentedJun 5, 2025
edited by jaaydenh
Loading

Always show preset parameters in CreateWorkspacePageViewExperimental if the preset parameter has any diagnostics, regardless of the showPresetParameters toggle state.

This ensures that users can see and address errors in preset parameters even when the "Show preset parameters" toggle is disabled.

Fixescoder/internal#651

blink-sobotand others added2 commitsJune 5, 2025 18:44
Always show preset parameters in CreateWorkspacePageViewExperimentalif the preset parameter has any diagnostics, regardless of theshowPresetParameters toggle state.Fixes#651
@jaaydenhjaaydenh self-assigned thisJun 5, 2025
@jaaydenhjaaydenh requested a review fromEmyrkJune 5, 2025 20:47
@jaaydenhjaaydenh merged commitb4f71b7 intomainJun 5, 2025
35 checks passed
@jaaydenhjaaydenh deleted the fix/show-preset-parameters-with-diagnostics branchJune 5, 2025 21:46
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 5, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display preset error notification when there is an error on a hidden preset parameter
2 participants
@Emyrk@jaaydenh

[8]ページ先頭

©2009-2025 Movatter.jp