- Notifications
You must be signed in to change notification settings - Fork905
chore: cherry-pick bug fixes for release 2.23#18219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+346 −195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
(cherry picked from commit216fe44)
…18059)The existing code persists all static parameters and their values. Usingthe previous build as the source if no new inputs are found.Dynamic params do not have a state of the parameters saved to disk. Soinstead, all previous values are persisted always, and new inputsoverride.(cherry picked from commitca8660c)
Workspace creation page<img width="1438" alt="Screenshot 2025-05-30 at 13 38 22"src="https://github.com/user-attachments/assets/bac94f3a-b695-4662-9a89-7777d03d8f74"/>Workspace parameter settings<img width="1432" alt="Screenshot 2025-05-30 at 13 37 19"src="https://github.com/user-attachments/assets/f1f803a6-b99a-416c-a085-38bafc2ef4e4"/><img width="1429" alt="Screenshot 2025-05-30 at 13 43 27"src="https://github.com/user-attachments/assets/cb1d37a4-8b79-4858-846e-3b1deb0a63cf"/>(cherry picked from commit9b53e69)
…sh` (#18093)Closes#18088.The linked issue is misleading -- `coder config-ssh` continues to support the `coder.` prefix. The reason the command`ssh coder.workspace.agent` fails is because `coder ssh workspace.agent` wasn't supported. This PR fixes that.We know we used to support `workspace.agent`, as this is what we recommend in the Web UI:This PR also adds support for `coder ssh agent.workspace.owner`, such that after running `coder config-ssh`, a command like```ssh agent.workspace.owner.coder```works, even without Coder Connect running. This is done for parity with an existing workflow that uses `ssh workspace.coder`, which either uses Coder Connect if available, or the CLI.(cherry picked from commitda02375)
kylecarbs approved these changesJun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just stamping so Kirby can merge. He's reviewing.
3a68676 intorelease/2.23 41 of 43 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks for release 2.23.