- Notifications
You must be signed in to change notification settings - Fork925
docs: update deployments experiments for June 3 release#18196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
EdwardAngert wants to merge10 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+60 −136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
stirby approved these changesJun 3, 2025
@stirby - looks like it's failing because it's not as straightforward as just removing it from |
- Remove ExperimentWorkspaceUsage, ExperimentNotifications, and ExperimentWebPush- Enable workspace usage tracking by default in telemetry and metrics- Enable web push notifications by default- Update all references throughout codebase including tests- Remove experiment checks that were causing compilation errorsCo-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com>
Co-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com>
- Remove web-push experiment check from useWebpushNotifications- Remove notifications experiment from storybook configurations- Enable web push and notifications by default in frontendCo-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com>
…fectThe enabledExperimentsQuery.data dependency was not used within the useEffecthook and was causing a linting error. The effect only sets enabled state,checks browser support, and verifies subscription status.Co-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com>
The test was experiencing a data race where the collected map was beingmodified in the assert.Eventuallyf goroutine while being read by cmp.Diff.Fixed by creating a local map in each iteration and only assigning it tothe shared variable when the comparison succeeds, eliminating concurrentaccess to the same map.Co-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com>
matifali requested changesJun 21, 2025
Comment on lines +60 to +64
| // Session stats are now handled by the CLI and the postWorkspaceUsage route. | ||
| req.Stats.SessionCountSsh = 0 | ||
| req.Stats.SessionCountJetbrains = 0 | ||
| req.Stats.SessionCountVscode = 0 | ||
| req.Stats.SessionCountReconnectingPty = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These changes look unrelated.
We are not graduating theworkspace-usage experiment.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#18083