- Notifications
You must be signed in to change notification settings - Fork906
fix(site): ensure test proxy providers can't have wiped fields#18062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Closed
Changes fromall commits
Commits
Show all changes
6 commits Select commitHold shift + click to select a range
a77e453
fix: ensure test proxy providers can't have wiped fields
Parkreiner4243197
fix: update condition
Parkreiner71a0eaa
fix: make condition even more airtight
Parkreiner1c81926
Merge branch 'main' into mes/provider-patch
Parkreiner40930e3
refactor: switch to lodash
Parkreinerd312898
fix: format
ParkreinerFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
60 changes: 34 additions & 26 deletionssite/src/testHelpers/storybook.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -10,6 +10,7 @@ import { | ||
getPreferredProxy, | ||
} from "contexts/ProxyContext"; | ||
import { AuthProvider } from "contexts/auth/AuthProvider"; | ||
import _ from "lodash"; | ||
import { DashboardContext } from "modules/dashboard/DashboardProvider"; | ||
import { DeploymentConfigContext } from "modules/management/DeploymentConfigProvider"; | ||
import { OrganizationSettingsContext } from "modules/management/OrganizationSettingsLayout"; | ||
@@ -162,29 +163,36 @@ export const withOrganizationSettingsProvider = (Story: FC) => { | ||
); | ||
}; | ||
const baselineProxyProvider: ProxyContextValue = { | ||
proxyLatencies: MockProxyLatencies, | ||
proxy: getPreferredProxy([], undefined), | ||
proxies: [], | ||
isLoading: false, | ||
isFetched: true, | ||
setProxy: () => { | ||
return; | ||
}, | ||
clearProxy: () => { | ||
return; | ||
}, | ||
refetchProxyLatencies: (): Date => { | ||
return new Date(); | ||
}, | ||
}; | ||
export const withProxyProvider = (provider?: Partial<ProxyContextValue>) => { | ||
// Not using the spread operator to combine the values, because there's a | ||
// risk that it will wipe fields from the baseline provider if the incoming | ||
// provider isn't defined properly | ||
let merged = baselineProxyProvider; | ||
if (provider !== undefined) { | ||
merged = { ...baselineProxyProvider }; | ||
_.defaults(merged, [provider]); | ||
} | ||
Parkreiner marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
return (Story: FC) => ( | ||
<ProxyContext.Provider value={merged}> | ||
<Story /> | ||
</ProxyContext.Provider> | ||
); | ||
}; |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.