- Notifications
You must be signed in to change notification settings - Fork929
feat: bypass built-in CORS handling for workspace apps#15669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Closed
Changes from1 commit
Commits
Show all changes
12 commits Select commitHold shift + click to select a range
0dc7ca3
Working implementation
dannykopping3c0e33a
Rename CorsBehavior to CORSBehavior
dannykoppinga4d3c8d
Hard & simplify CORORS handling logic
dannykopping873c3e4
Minor fixes
dannykopping65f984f
Appeasing the linter
dannykopping1f0b34c
Move type def to codersdk
dannykopping5be5477
Appease the linter, again
dannykoppingddbbaa9
Fix migration num
dannykopping63c1852
Removing unnecessary header check
dannykopping976cd78
Improve tests
dannykopping9f9068f
Merge branch 'main' of https://github.com/coder/coder into dk/cors
dannykopping3dc00e1
Comprehensive CORS test suite for both request & response
dannykoppingFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
PrevPrevious commit
Comprehensive CORS test suite for both request & response
Signed-off-by: Danny Kopping <danny@coder.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit3dc00e1dc58d50f0c033b9c63d79e8fda9afcbb4
There are no files selected for viewing
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.