Commitdc24922

authored

fix: use the correct key for tasks tab visibility in embedded metadata (#18539)

The backend (introduced in#18401)actually puts the value under the `tasks-tab-visible` key instead of the`tasksTabVisible`:

1 parentf44969b commitdc24922Copy full SHA for dc24922

File tree

-6

lines changed

-6

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ const mockDataForTags = {`
`42`	`42`	`user:MockUserOwner,`
`43`	`43`	`userAppearance:MockUserAppearanceSettings,`
`44`	`44`	`regions:MockRegions,`
`45`		`-tasksTabVisible:MockTasksTabVisible,`
	`45`	`+"tasks-tab-visible":MockTasksTabVisible,`
`46`	`46`	`}asconstsatisfiesRecord<MetadataKey,MetadataValue>;`
`47`	`47`
`48`	`48`	`constemptyMetadata:RuntimeHtmlMetadata={`
`@@ -74,7 +74,7 @@ const emptyMetadata: RuntimeHtmlMetadata = {`
`74`	`74`	`available:false,`
`75`	`75`	`value:undefined,`
`76`	`76`	`},`
`77`		`-tasksTabVisible:{`
	`77`	`+"tasks-tab-visible":{`
`78`	`78`	`available:false,`
`79`	`79`	`value:undefined,`
`80`	`80`	`},`
`@@ -109,7 +109,7 @@ const populatedMetadata: RuntimeHtmlMetadata = {`
`109`	`109`	`available:true,`
`110`	`110`	`value:MockUserAppearanceSettings,`
`111`	`111`	`},`
`112`		`-tasksTabVisible:{`
	`112`	`+"tasks-tab-visible":{`
`113`	`113`	`available:true,`
`114`	`114`	`value:MockTasksTabVisible,`
`115`	`115`	`},`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ type AvailableMetadata = Readonly<{`
`30`	`30`	`entitlements:Entitlements;`
`31`	`31`	`regions:readonlyRegion[];`
`32`	`32`	`"build-info":BuildInfoResponse;`
`33`		`-tasksTabVisible:boolean;`
	`33`	`+"tasks-tab-visible":boolean;`
`34`	`34`	`}>;`
`35`	`35`
`36`	`36`	`exporttypeMetadataKey=keyofAvailableMetadata;`
`@@ -92,7 +92,7 @@ export class MetadataManager implements MetadataManagerApi {`
`92`	`92`	`experiments:this.registerValue<Experiment[]>("experiments"),`
`93`	`93`	`"build-info":this.registerValue<BuildInfoResponse>("build-info"),`
`94`	`94`	`regions:this.registerRegionValue(),`
`95`		`-tasksTabVisible:this.registerValue<boolean>("tasksTabVisible"),`
	`95`	`+"tasks-tab-visible":this.registerValue<boolean>("tasks-tab-visible"),`
`96`	`96`	`};`
`97`	`97`	`}`
`98`	`98`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ const NavItems: FC<NavItemsProps> = ({ className }) => {`
`175`	`175`	`Chat`
`176`	`176`	`</NavLink>`
`177`	`177`	`)}`
`178`		`-{metadata.tasksTabVisible.value&&(`
	`178`	`+{metadata["tasks-tab-visible"].value&&(`
`179`	`179`	`<NavLink`
`180`	`180`	`className={({ isActive})=>{`
`181`	`181`	`returncn(linkStyles.default,isActive ?linkStyles.active :"");`

Comments

(0)