Commitb4f71b7

blink-so[bot]

and

jaaydenh

authored

fix: show preset parameters when they have diagnostics (#18258)

Always show preset parameters in CreateWorkspacePageViewExperimental ifthe preset parameter has any diagnostics, regardless of theshowPresetParameters toggle state.This ensures that users can see and address errors in preset parameterseven when the "Show preset parameters" toggle is disabled.Fixescoder/internal#651---------Co-authored-by: blink-so[bot] <211532188+blink-so[bot]@users.noreply.github.com>Co-authored-by: Jaayden Halko <jaayden@coder.com>

1 parent508fba8 commitb4f71b7Copy full SHA for b4f71b7

File tree

1 file changed

-2

lines changed

site/src/pages/CreateWorkspacePage
- CreateWorkspacePageViewExperimental.tsx

1 file changed

-2

lines changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -620,8 +620,12 @@ export const CreateWorkspacePageViewExperimental: FC<`
`620`	`620`	`creatingWorkspace\|\|`
`621`	`621`	`isPresetParameter;`
`622`	`622`
`623`		`-// Hide preset parameters if showPresetParameters is false`
`624`		`-if(!showPresetParameters&&isPresetParameter){`
	`623`	`+// Always show preset parameters if they have any diagnostics`
	`624`	`+if(`
	`625`	`+!showPresetParameters&&`
	`626`	`+isPresetParameter&&`
	`627`	`+parameter.diagnostics.length===0`
	`628`	`+){`
`625`	`629`	`returnnull;`
`626`	`630`	`}`
`627`	`631`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb4f71b7

File tree

1 file changed

1 file changed

`‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx`

0 commit comments