Commitb187d33

authored

fix: show exclamation mark on negated permissions in org custom roles page (#21314)

Some permissions (in built-in roles only) have `Negated: true`, so theUI was misleading users by showing that they had those permissions whenthey really didn't.<img width="1053" height="81" alt="image"src="https://github.com/user-attachments/assets/ccf072ed-5821-4eb6-ac75-a1a563cf55c5"/>

1 parente4a06f8 commitb187d33Copy full SHA for b187d33

File tree

-1

lines changed

site/src/pages/OrganizationSettingsPage/CustomRolesPage
- PermissionPillsList.tsx

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,8 @@ const PermissionsPill: FC<PermissionPillProps> = ({`
`59`	`59`
`60`	`60`	`return(`
`61`	`61`	`<Pillcss={styles.permissionPill}>`
`62`		`-<b>{resource}</b>:{actions.map((p)=>p.action).join(", ")}`
	`62`	`+<b>{resource}</b>:{" "}`
	`63`	+{actions.map((p)=>`${p.negate ?"!" :""}${p.action}`).join(", ")}
`63`	`64`	`</Pill>`
`64`	`65`	`);`
`65`	`66`	`};`

Comments

(0)