Commitaba8129

committed

chore: show status when message is blank

The status row looks janky with just the icon. We can get into a "nomessage" state if the LLM never reported a status update.

1 parent5aa909c commitaba8129Copy full SHA for aba8129

File tree

+35

-4

lines changed

+35

-4

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,16 @@ export const Idle: Story = {`
`49`	`49`	`},`
`50`	`50`	`};`
`51`	`51`
	`52`	`+exportconstNoMessage:Story={`
	`53`	`+args:{`
	`54`	`+status:{`
	`55`	`+...MockWorkspaceAppStatus,`
	`56`	`+state:"idle",`
	`57`	`+message:"",`
	`58`	`+},`
	`59`	`+},`
	`60`	`+};`
	`61`	`+`
`52`	`62`	`exportconstLongMessage:Story={`
`53`	`63`	`args:{`
`54`	`64`	`status:{`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ import {`
`5`	`5`	`TooltipProvider,`
`6`	`6`	`TooltipTrigger,`
`7`	`7`	`}from"components/Tooltip/Tooltip";`
	`8`	`+importcapitalizefrom"lodash/capitalize";`
`8`	`9`	`import{AppStatusStateIcon}from"modules/apps/AppStatusStateIcon";`
`9`	`10`	`import{cn}from"utils/cn";`
`10`	`11`
`@@ -25,6 +26,7 @@ export const WorkspaceAppStatus = ({`
`25`	`26`	`);`
`26`	`27`	`}`
`27`	`28`
	`29`	`+constmessage=status.message\|\|capitalize(status.state);`
`28`	`30`	`return(`
`29`	`31`	`<divclassName="flex flex-col text-content-secondary">`
`30`	`32`	`<TooltipProvider>`
`@@ -40,11 +42,11 @@ export const WorkspaceAppStatus = ({`
`40`	`42`	`})}`
`41`	`43`	`/>`
`42`	`44`	`<spanclassName="whitespace-nowrap max-w-72 overflow-hidden text-ellipsis text-sm text-content-primary font-medium">`
`43`		`-{status.message}`
	`45`	`+{message}`
`44`	`46`	`</span>`
`45`	`47`	`</div>`
`46`	`48`	`</TooltipTrigger>`
`47`		`-<TooltipContent>{status.message}</TooltipContent>`
	`49`	`+<TooltipContent>{message}</TooltipContent>`
`48`	`50`	`</Tooltip>`
`49`	`51`	`</TooltipProvider>`
`50`	`52`	`<spanclassName="text-xs first-letter:uppercase block pl-6">`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,24 @@ export const IdleState: Story = {`
`64`	`64`	`]),`
`65`	`65`	`},`
`66`	`66`	`};`
	`67`	`+`
	`68`	`+exportconstNoMessage:Story={`
	`69`	`+args:{`
	`70`	`+agent:mockAgent([`
	`71`	`+{`
	`72`	`+...MockWorkspaceAppStatus,`
	`73`	`+id:"status-8",`
	`74`	`+icon:"",`
	`75`	`+message:"",`
	`76`	`+created_at:createTimestamp(5,20),`
	`77`	`+uri:"",`
	`78`	`+state:"idle"asconst,`
	`79`	`+},`
	`80`	`+...MockWorkspaceAppStatuses,`
	`81`	`+]),`
	`82`	`+},`
	`83`	`+};`
	`84`	`+`
`67`	`85`	`exportconstLongStatusText:Story={`
`68`	`86`	`args:{`
`69`	`87`	`agent:mockAgent([`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ import {`
`12`	`12`	`TooltipProvider,`
`13`	`13`	`TooltipTrigger,`
`14`	`14`	`}from"components/Tooltip/Tooltip";`
	`15`	`+importcapitalizefrom"lodash/capitalize";`
`15`	`16`	`import{timeFrom}from"utils/time";`
`16`	`17`
`17`	`18`	`import{`
`@@ -77,7 +78,7 @@ export const AppStatuses: FC<AppStatusesProps> = ({`
`77`	`78`	`<divclassName="text-sm font-medium text-content-primary flex items-center gap-2 ">`
`78`	`79`	`<AppStatusStateIconstate={latestStatus.state}latest/>`
`79`	`80`	`<spanclassName="block flex-1 whitespace-nowrap overflow-hidden text-ellipsis">`
`80`		`-{latestStatus.message}`
	`81`	`+{latestStatus.message\|\|capitalize(latestStatus.state)}`
`81`	`82`	`</span>`
`82`	`83`	`</div>`
`83`	`84`	`<spanclassName="text-xs text-content-secondary first-letter:uppercase block pl-[26px]">`
`@@ -160,7 +161,7 @@ export const AppStatuses: FC<AppStatusesProps> = ({`
`160`	`161`	`latest={false}`
`161`	`162`	`className="size-icon-xs w-[18px]"`
`162`	`163`	`/>`
`163`		`-{status.message}`
	`164`	`+{status.message\|\|capitalize(status.state)}`
`164`	`165`	`</span>`
`165`	`166`	`<spanclassName="text-2xs text-content-secondary first-letter:uppercase block pl-[26px]">`
`166`	`167`	`{formattedTimestamp}`

Comments

(0)