Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit9c47733

Browse files
ci: allow more time for gen & fmt jobs to be acquired (#20577)
Closescoder/internal#1081The time taken for a runner to acquire a job counts towards the job-wide `timeout-minutes`. Recently we've been seeing outages in the runner infrastructure lead to a ~5-6m runner start time, causing fmt & gen jobs to be cancelled due to their 7 or 8 minute timeouts.This PR extends the job-wide timeout on fmt & gen to 20 minutes, but adds the original 7 and 8 minute timeouts to the `make [fmt|gen]` portion of the job -- the part of the job we have the most control over, and that we want to be made aware of timeouts for.
1 parent139dab7 commit9c47733

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

‎.github/workflows/ci.yaml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ jobs:
230230
shell:bash
231231

232232
gen:
233-
timeout-minutes:8
233+
timeout-minutes:20
234234
runs-on:${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
235235
if:${{ !cancelled() }}
236236
steps:
@@ -271,6 +271,7 @@ jobs:
271271
popd
272272
273273
-name:make gen
274+
timeout-minutes:8
274275
run:|
275276
# Remove golden files to detect discrepancy in generated files.
276277
make clean/golden-files
@@ -288,7 +289,7 @@ jobs:
288289
needs:changes
289290
if:needs.changes.outputs.offlinedocs-only == 'false' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main'
290291
runs-on:${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
291-
timeout-minutes:7
292+
timeout-minutes:20
292293
steps:
293294
-name:Harden Runner
294295
uses:step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a# v2.13.1
@@ -315,6 +316,7 @@ jobs:
315316
run:go install mvdan.cc/sh/v3/cmd/shfmt@v3.7.0
316317

317318
-name:make fmt
319+
timeout-minutes:7
318320
run:|
319321
PATH="${PATH}:$(go env GOPATH)/bin" \
320322
make --output-sync -j -B fmt

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp