Commit8c2b457

blink-so[bot]

and

kylecarbs

committed

fix: remove unused import and fix proxy auto-selection race condition

- Remove unused useMutation import to fix lint error- Fix updateProxy to use loadUserSelectedProxy() directly instead of stale userSavedProxy variable- This ensures updateProxy always uses current localStorage value after auto-selectionCo-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>

1 parent1697b42 commit8c2b457Copy full SHA for 8c2b457

File tree

1 file changed

-3

lines changed

site/src/contexts
- ProxyContext.tsx

1 file changed

-3

lines changed

`‎site/src/contexts/ProxyContext.tsx`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ import {`
`13`	`13`	`useMemo,`
`14`	`14`	`useState,`
`15`	`15`	`}from"react";`
`16`		`-import{useMutation,useQuery,useQueryClient}from"react-query";`
	`16`	`+import{useQuery,useQueryClient}from"react-query";`
`17`	`17`
`18`	`18`	`import{typeProxyLatencyReport,useProxyLatency}from"./useProxyLatency";`
`19`	`19`
`@@ -141,15 +141,15 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {`
`141`	`141`	`setProxy(`
`142`	`142`	`getPreferredProxy(`
`143`	`143`	`proxiesResp??[],`
`144`		`-userSavedProxy,`
	`144`	`+loadUserSelectedProxy(),`
`145`	`145`	`proxyLatencies,`
`146`	`146`	`// Do not auto select based on latencies, as inconsistent latencies can cause this`
`147`	`147`	`// to change on each call. updateProxy should be stable when selecting a proxy to`
`148`	`148`	`// prevent flickering.`
`149`	`149`	`false,`
`150`	`150`	`),`
`151`	`151`	`);`
`152`		`-},[proxiesResp,proxyLatencies,userSavedProxy]);`
	`152`	`+},[proxiesResp,proxyLatencies]);`
`153`	`153`
`154`	`154`	`// This useEffect ensures the proxy to be used is updated whenever the state changes.`
`155`	`155`	`// This includes proxies being loaded, latencies being calculated, and the user selecting a proxy.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8c2b457

File tree

1 file changed

1 file changed

`‎site/src/contexts/ProxyContext.tsx`

0 commit comments