Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit80e52ee

Browse files
minor fixes
1 parenta93b654 commit80e52ee

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

‎enterprise/coderd/prebuilds/reconcile.go

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -619,14 +619,17 @@ func (c *StoreReconciler) executeReconciliationAction(ctx context.Context, logge
619619
// Unexpected things happen (i.e. bugs or bitflips); let's defend against disastrous outcomes.
620620
// See https://blog.robertelder.org/causes-of-bit-flips-in-computer-memory/.
621621
// This is obviously not comprehensive protection against this sort of problem, but this is one essential check.
622-
// TODO: uncomment:
623-
// desired := ps.Preset.DesiredInstances.Int32
624-
// if action.Create > desired {
625-
//logger.Critical(ctx, "determined excessive count of prebuilds to create; clamping to desired count",
626-
//slog.F("create_count", action.Create), slog.F("desired_count", desired))
627-
//
628-
//action.Create = desired
629-
//}
622+
desired,err:=ps.CalculateDesiredInstances(c.clock.Now())
623+
iferr!=nil {
624+
returnxerrors.Errorf("failed to calculate desired instances: %w",err)
625+
}
626+
627+
ifaction.Create>desired {
628+
logger.Critical(ctx,"determined excessive count of prebuilds to create; clamping to desired count",
629+
slog.F("create_count",action.Create),slog.F("desired_count",desired))
630+
631+
action.Create=desired
632+
}
630633

631634
// If preset is hard-limited, and it's a create operation, log it and exit early.
632635
// Creation operation is disallowed for hard-limited preset.

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp