Commit7ef638f

blink-so[bot]

and

kylecarbs

committed

fix: revert userSavedProxy from auto-selection useEffect dependencies

The auto-selection useEffect should not include userSavedProxy in itsdependencies as it should only run when latencies are loaded, not whenthe user proxy changes. The check inside the useEffect is sufficient.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>

1 parent34b40da commit7ef638fCopy full SHA for 7ef638f

File tree

1 file changed

-1

lines changed

site/src/contexts
- ProxyContext.tsx

1 file changed

-1

lines changed

`‎site/src/contexts/ProxyContext.tsx`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {`
`211`	`211`	`saveUserSelectedProxy(best.proxy);`
`212`	`212`	`updateProxy();`
`213`	`213`	`}`
`214`		`-},[latenciesLoaded,proxiesResp,proxyLatencies,userSavedProxy]);`
	`214`	`+},[latenciesLoaded,proxiesResp,proxyLatencies]);`
`215`	`215`
`216`	`216`	`return(`
`217`	`217`	`<ProxyContext.Provider`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7ef638f

File tree

1 file changed

1 file changed

`‎site/src/contexts/ProxyContext.tsx`

0 commit comments