NotificationsYou must be signed in to change notification settings
Fork909
Star10k

Commit7c2fb66

authored

chore(provisionersdk): ignore io.EOF in Session.requestReader (#18234)

My understanding is that `io.EOF` is eventually expected, so logging itas an error may be confusing. For other errors we should definitelyWARN.```[info] provisionerd-ip-172-31-12-44-14: recv done on Session session_id=22b9ef8a-9cd6-4188-98e0-573a50d724cc error=EOF```

1 parent08eff7f commit7c2fb66Copy full SHA for 7c2fb66

File tree

1 file changed

-1

lines changed

provisionersdk
- session.go

1 file changed

-1

lines changed

`‎provisionersdk/session.go`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,11 @@ func (s Session) requestReader(done <-chan struct{}) <-chan proto.Request {`
`100`	`100`	`for {`
`101`	`101`	`req,err:=s.stream.Recv()`
`102`	`102`	`iferr!=nil {`
`103`		`-s.Logger.Info(s.Context(),"recv done on Session",slog.Error(err))`
	`103`	`+if!xerrors.Is(err,io.EOF) {`
	`104`	`+s.Logger.Warn(s.Context(),"recv done on Session",slog.Error(err))`
	`105`	`+}else {`
	`106`	`+s.Logger.Info(s.Context(),"recv done on Session")`
	`107`	`+}`
`104`	`108`	`return`
`105`	`109`	`}`
`106`	`110`	`select {`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7c2fb66

File tree

1 file changed

1 file changed

`‎provisionersdk/session.go`

0 commit comments