Commit643fe38

authored

fix: use temp file on same device with mcp file edit (#20477)

Otherwise you can get errors like "invalid cross-device link".

1 parentc827a08 commit643fe38Copy full SHA for 643fe38

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,9 @@ func (a *agent) editFile(ctx context.Context, path string, edits []workspacesdk.`
`250`	`250`	`transforms[i]=replace.String(edit.Search,edit.Replace)`
`251`	`251`	`}`
`252`	`252`
`253`		`-tmpfile,err:=afero.TempFile(a.filesystem,"",filepath.Base(path))`
	`253`	`+// Create an adjacent file to ensure it will be on the same device and can be`
	`254`	`+// moved atomically.`
	`255`	`+tmpfile,err:=afero.TempFile(a.filesystem,filepath.Dir(path),filepath.Base(path))`
`254`	`256`	`iferr!=nil {`
`255`	`257`	`returnhttp.StatusInternalServerError,err`
`256`	`258`	`}`

Comments

(0)