Commit634144f

and

authored

fix: hide the preset parameter visibility switch when it has no effect (#18574)

When no preset is selected:<img width="1097" alt="Screenshot 2025-06-25 at 15 49 51"src="https://github.com/user-attachments/assets/96f1244a-58f1-4e59-b6ac-9319339c764f"/>When a preset is selected:<img width="1097" alt="Screenshot 2025-06-25 at 15 50 00"src="https://github.com/user-attachments/assets/d0853169-ff93-4b1a-beaf-11012a9a02fb"/>Existing frontend stories provide enough validation to cover thisfeature. No further testing is required.---------Co-authored-by: Susana Ferreira <susana@coder.com>

1 parentfb0e7a2 commit634144fCopy full SHA for 634144f

File tree

+36

-29

lines changed

+36

-29

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -277,6 +277,8 @@ export const PresetsWithDefault: Story = {`
`277`	`277`	`},`
`278`	`278`	`play:async({ canvasElement})=>{`
`279`	`279`	`constcanvas=within(canvasElement);`
	`280`	`+// Wait for the switch to be available since preset parameters are populated asynchronously`
	`281`	`+awaitcanvas.findByLabelText("Show preset parameters");`
`280`	`282`	`// Toggle off the show preset parameters switch`
`281`	`283`	`awaituserEvent.click(canvas.getByLabelText("Show preset parameters"));`
`282`	`284`	`},`

Lines changed: 21 additions & 18 deletions

Original file line number	Diff line number	Diff line change
`@@ -385,25 +385,28 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({`
`385`	`385`	`selectedOption={presetOptions[selectedPresetIndex]}`
`386`	`386`	`/>`
`387`	`387`	`</Stack>`
`388`		`-<div`
`389`		`-css={{`
`390`		`-display:"flex",`
`391`		`-alignItems:"center",`
`392`		`-gap:"8px",`
`393`		`-}}`
`394`		`->`
`395`		`-<Switch`
`396`		`-id="show-preset-parameters"`
`397`		`-checked={showPresetParameters}`
`398`		`-onCheckedChange={setShowPresetParameters}`
`399`		`-/>`
`400`		`-<label`
`401`		`-htmlFor="show-preset-parameters"`
`402`		`-css={styles.description}`
	`388`	`+{/* Only show the preset parameter visibility toggle if preset parameters are actually being modified, otherwise it has no effect. */}`
	`389`	`+{presetParameterNames.length>0&&(`
	`390`	`+<div`
	`391`	`+css={{`
	`392`	`+display:"flex",`
	`393`	`+alignItems:"center",`
	`394`	`+gap:"8px",`
	`395`	`+}}`
`403`	`396`	`>`
`404`		`-Show preset parameters`
`405`		`-</label>`
`406`		`-</div>`
	`397`	`+<Switch`
	`398`	`+id="show-preset-parameters"`
	`399`	`+checked={showPresetParameters}`
	`400`	`+onCheckedChange={setShowPresetParameters}`
	`401`	`+/>`
	`402`	`+<label`
	`403`	`+htmlFor="show-preset-parameters"`
	`404`	`+css={styles.description}`
	`405`	`+>`
	`406`	`+Show preset parameters`
	`407`	`+</label>`
	`408`	`+</div>`
	`409`	`+)}`
`407`	`410`	`</Stack>`
`408`	`411`	`</Stack>`
`409`	`412`	`)}`

Lines changed: 13 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,6 @@ export const CreateWorkspacePageViewExperimental: FC<`
`562`	`562`	`<divclassName="flex flex-col gap-2">`
`563`	`563`	`<divclassName="flex gap-2 items-center">`
`564`	`564`	`<LabelclassName="text-sm">Preset</Label>`
`565`		`-<FeatureStageBadgecontentType={"beta"}size="sm"/>`
`566`	`565`	`</div>`
`567`	`566`	`<divclassName="flex flex-col gap-4">`
`568`	`567`	`<divclassName="max-w-lg">`
`@@ -594,16 +593,19 @@ export const CreateWorkspacePageViewExperimental: FC<`
`594`	`593`	`</SelectContent>`
`595`	`594`	`</Select>`
`596`	`595`	`</div>`
`597`		`-<spanclassName="flex items-center gap-3">`
`598`		`-<Switch`
`599`		`-id="show-preset-parameters"`
`600`		`-checked={showPresetParameters}`
`601`		`-onCheckedChange={setShowPresetParameters}`
`602`		`-/>`
`603`		`-<LabelhtmlFor="show-preset-parameters">`
`604`		`-Show preset parameters`
`605`		`-</Label>`
`606`		`-</span>`
	`596`	`+{/* Only show the preset parameter visibility toggle if preset parameters are actually being modified, otherwise it is ineffectual */}`
	`597`	`+{presetParameterNames.length>0&&(`
	`598`	`+<spanclassName="flex items-center gap-3">`
	`599`	`+<Switch`
	`600`	`+id="show-preset-parameters"`
	`601`	`+checked={showPresetParameters}`
	`602`	`+onCheckedChange={setShowPresetParameters}`
	`603`	`+/>`
	`604`	`+<LabelhtmlFor="show-preset-parameters">`
	`605`	`+Show preset parameters`
	`606`	`+</Label>`
	`607`	`+</span>`
	`608`	`+)}`
`607`	`609`	`</div>`
`608`	`610`	`</div>`
`609`	`611`	`)}`

Comments

(0)