NotificationsYou must be signed in to change notification settings
Fork906
Star10k

Commit60595f3

authored

chore: ignore.git directories in terraform modules (#18255)

.git directories were causing identical modules to have differenthashes. This adds unecessary bloat to the database, and the .gitdirectory is not needed for dynamic params

1 parent3f406c7 commit60595f3Copy full SHA for 60595f3

File tree

1 file changed

-0

lines changed

provisioner/terraform
- modules.go

1 file changed

-0

lines changed

`‎provisioner/terraform/modules.go`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,13 @@ func GetModulesArchive(root fs.FS) ([]byte, error) {`
`103`	`103`	`if!fileMode.IsRegular()&&!fileMode.IsDir() {`
`104`	`104`	`returnnil`
`105`	`105`	`}`
	`106`	`+`
	`107`	`+// .git directories are not needed in the archive and only cause`
	`108`	`+// hash differences for identical modules.`
	`109`	`+iffileMode.IsDir()&&d.Name()==".git" {`
	`110`	`+returnfs.SkipDir`
	`111`	`+}`
	`112`	`+`
`106`	`113`	`fileInfo,err:=d.Info()`
`107`	`114`	`iferr!=nil {`
`108`	`115`	`returnxerrors.Errorf("failed to archive module file %q: %w",filePath,err)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit60595f3

File tree

1 file changed

1 file changed

`‎provisioner/terraform/modules.go`

0 commit comments