Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit47ea9b2

Browse files
committed
chore: dbauthz
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
1 parent8e15791 commit47ea9b2

File tree

2 files changed

+64
-1
lines changed

2 files changed

+64
-1
lines changed

‎coderd/database/dbauthz/dbauthz.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4884,7 +4884,18 @@ func (q *querier) UpdateWorkspaceAutostart(ctx context.Context, arg database.Upd
48844884
}
48854885

48864886
func (q*querier)UpdateWorkspaceBuildAITaskByID(ctx context.Context,arg database.UpdateWorkspaceBuildAITaskByIDParams)error {
4887-
iferr:=q.authorizeContext(ctx,policy.ActionUpdate,rbac.ResourceSystem);err!=nil {
4887+
build,err:=q.db.GetWorkspaceBuildByID(ctx,arg.ID)
4888+
iferr!=nil {
4889+
returnerr
4890+
}
4891+
4892+
workspace,err:=q.db.GetWorkspaceByID(ctx,build.WorkspaceID)
4893+
iferr!=nil {
4894+
returnerr
4895+
}
4896+
4897+
err=q.authorizeContext(ctx,policy.ActionUpdate,workspace.RBACObject())
4898+
iferr!=nil {
48884899
returnerr
48894900
}
48904901
returnq.db.UpdateWorkspaceBuildAITaskByID(ctx,arg)

‎coderd/database/dbauthz/dbauthz_test.go

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1392,6 +1392,24 @@ func (s *MethodTestSuite) TestTemplate() {
13921392
ID:t1.ID,
13931393
}).Asserts(t1,policy.ActionUpdate)
13941394
}))
1395+
s.Run("UpdateTemplateVersionAITaskByJobID",s.Subtest(func(db database.Store,check*expects) {
1396+
dbtestutil.DisableForeignKeysAndTriggers(s.T(),db)
1397+
o:=dbgen.Organization(s.T(),db, database.Organization{})
1398+
u:=dbgen.User(s.T(),db, database.User{})
1399+
_=dbgen.OrganizationMember(s.T(),db, database.OrganizationMember{OrganizationID:o.ID,UserID:u.ID})
1400+
t:=dbgen.Template(s.T(),db, database.Template{OrganizationID:o.ID,CreatedBy:u.ID})
1401+
job:=dbgen.ProvisionerJob(s.T(),db,nil, database.ProvisionerJob{OrganizationID:o.ID})
1402+
_=dbgen.TemplateVersion(s.T(),db, database.TemplateVersion{
1403+
OrganizationID:o.ID,
1404+
CreatedBy:u.ID,
1405+
JobID:job.ID,
1406+
TemplateID: uuid.NullUUID{UUID:t.ID,Valid:true},
1407+
})
1408+
check.Args(database.UpdateTemplateVersionAITaskByJobIDParams{
1409+
JobID:job.ID,
1410+
HasAITask: sql.NullBool{Bool:true,Valid:true},
1411+
}).Asserts(t,policy.ActionUpdate)
1412+
}))
13951413
s.Run("UpdateTemplateWorkspacesLastUsedAt",s.Subtest(func(db database.Store,check*expects) {
13961414
dbtestutil.DisableForeignKeysAndTriggers(s.T(),db)
13971415
t1:=dbgen.Template(s.T(),db, database.Template{})
@@ -3051,6 +3069,40 @@ func (s *MethodTestSuite) TestWorkspace() {
30513069
Deadline:b.Deadline,
30523070
}).Asserts(w,policy.ActionUpdate)
30533071
}))
3072+
s.Run("UpdateWorkspaceBuildAITaskByID",s.Subtest(func(db database.Store,check*expects) {
3073+
u:=dbgen.User(s.T(),db, database.User{})
3074+
o:=dbgen.Organization(s.T(),db, database.Organization{})
3075+
tpl:=dbgen.Template(s.T(),db, database.Template{
3076+
OrganizationID:o.ID,
3077+
CreatedBy:u.ID,
3078+
})
3079+
tv:=dbgen.TemplateVersion(s.T(),db, database.TemplateVersion{
3080+
TemplateID: uuid.NullUUID{UUID:tpl.ID,Valid:true},
3081+
OrganizationID:o.ID,
3082+
CreatedBy:u.ID,
3083+
})
3084+
w:=dbgen.Workspace(s.T(),db, database.WorkspaceTable{
3085+
TemplateID:tpl.ID,
3086+
OrganizationID:o.ID,
3087+
OwnerID:u.ID,
3088+
})
3089+
j:=dbgen.ProvisionerJob(s.T(),db,nil, database.ProvisionerJob{
3090+
Type:database.ProvisionerJobTypeWorkspaceBuild,
3091+
})
3092+
b:=dbgen.WorkspaceBuild(s.T(),db, database.WorkspaceBuild{
3093+
JobID:j.ID,
3094+
WorkspaceID:w.ID,
3095+
TemplateVersionID:tv.ID,
3096+
})
3097+
res:=dbgen.WorkspaceResource(s.T(),db, database.WorkspaceResource{JobID:b.JobID})
3098+
agt:=dbgen.WorkspaceAgent(s.T(),db, database.WorkspaceAgent{ResourceID:res.ID})
3099+
app:=dbgen.WorkspaceApp(s.T(),db, database.WorkspaceApp{AgentID:agt.ID})
3100+
check.Args(database.UpdateWorkspaceBuildAITaskByIDParams{
3101+
HasAITask: sql.NullBool{Bool:true,Valid:true},
3102+
SidebarAppID: uuid.NullUUID{UUID:app.ID,Valid:true},
3103+
ID:b.ID,
3104+
}).Asserts(w,policy.ActionUpdate)
3105+
}))
30543106
s.Run("SoftDeleteWorkspaceByID",s.Subtest(func(db database.Store,check*expects) {
30553107
u:=dbgen.User(s.T(),db, database.User{})
30563108
o:=dbgen.Organization(s.T(),db, database.Organization{})

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp