NotificationsYou must be signed in to change notification settings
Fork948
Star10.5k

Commit211393a

authored

fix: exclude prebuilt workspaces from lifecycle executor (#18762)

## DescriptionThis PR updates the lifecycle executor to explicitly exclude prebuiltworkspaces from being considered for lifecycle operations such as`autostart`, `autostop`, `dormancy`, `default TTL` and `failure TTL`.Prebuilt workspaces (i.e., those owned by the prebuild system user) arehandled separately by the prebuild reconciliation loop. Including themin the lifecycle executor could lead to unintended behavior such asincorrect scheduling or state transitions.## Changes* Updated the lifecycle executor query`GetWorkspacesEligibleForTransition` to exclude workspaces with`owner_id = 'c42fdf75-3097-471c-8c33-fb52454d81c0'` (prebuilds).* Added tests to verify prebuilt workspaces are not considered in: * Autostop * Autostart * Default TTL * Dormancy * Failure TTLFixes:#18740Related to:#18658

1 parent0118e75 commit211393aCopy full SHA for 211393a

File tree

14 files changed

+1204

-18

lines changed

coderd
- apidoc
  - docs.go
  - swagger.json
- autobuild
  - lifecycle_executor.go
  - lifecycle_executor_test.go
- database
  - dbgen
    - dbgen.go
  - queries.sql.go
  - queries
    - workspaces.sql
- schedule
  - autostart.go
codersdk
- workspacebuilds.go
docs
- admin/templates/extending-templates
  - prebuilt-workspaces.md
- reference/api
  - schemas.md
enterprise/coderd
- workspaces_test.go
site/src
- api
  - typesGenerated.ts
- utils
  - workspace.tsx

14 files changed

+1204

-18

lines changed

Original file line number	Diff line number	Diff line change
`@@ -520,6 +520,8 @@ func isEligibleForAutostart(user database.User, ws database.Workspace, build dat`
`520`	`520`	`returnfalse`
`521`	`521`	`}`
`522`	`522`
	`523`	`+// Get the next allowed autostart time after the build's creation time,`
	`524`	`+// based on the workspace's schedule and the template's allowed days.`
`523`	`525`	`nextTransition,err:=schedule.NextAllowedAutostart(build.CreatedAt,ws.AutostartSchedule.String,templateSchedule)`
`524`	`526`	`iferr!=nil {`
`525`	`527`	`returnfalse`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit211393a

File tree

14 files changed

14 files changed

`‎coderd/apidoc/docs.go`

`‎coderd/apidoc/swagger.json`

`‎coderd/autobuild/lifecycle_executor.go`

0 commit comments